cmake/plugins: Enable -Wswitch on GCC #11437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
force-pushed
the
switch_is_on_on_clang_so_gcc_will
branch
from
17c932a
to
30113ce
Compare
PatTheMav
approved these changes
Oct 24, 2024
RytoEX
requested changes
Oct 24, 2024
This warning is already enabled for Clang which causes issue for things that are usually built with MSVC or GCC (e.g. non-macOS plugins). obs-nvenc switch warning is also fixed in this commit. obs-qsv11 has switch warning set to not become errors.
tytan652
force-pushed
the
switch_is_on_on_clang_so_gcc_will
branch
from
30113ce
to
2cc916a
Compare
RytoEX
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11436
This warning is already enabled for Clang which causes issue for things that are usually built with MSVC or GCC (e.g. non-macOS plugins).
obs-nvenc switch warning is also fixed in this commit.
obs-qsv11 has switch warning set to not become errors.
Motivation and Context
Align more Clang and GCC common warnings.
How Has This Been Tested?
Just tried to build OBS with GCC and Clang locally.
Types of changes
Checklist: