-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize negative tests in QCheck #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased to latest |
jmid
changed the title
[WIP] Utilize negative tests in QCheck
Utilize negative tests in QCheck
Jun 15, 2022
|
jmid
force-pushed
the
qcheck-test-neg
branch
2 times, most recently
from
June 27, 2022 11:49
b8b264b
to
c5487bf
Compare
Rebased after merging #90 |
Rebased on latest main, having QCheck 0.19 with |
I just annotated the new DSL-ported tests with suitable |
(Hopefully) last rebasing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to try out the negative testing primitive
Test.make_neg
from c-cube/qcheck#244.It is intended to fix #29
Overall
neg_agree_test_par
directly in the source codecheck_error_count
can be eliminated entirely1
,2
, and4
errors indune
files are eliminated, anddune
files are generally simplifiedAs an added bonus, it opens up for switching to an alcotest runner as suggested in #15.
I would therefore argue that this is a clear win! \o/