Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lockfree tests from multicoretests repo here #14

Closed
wants to merge 2 commits into from

Conversation

lyrm
Copy link
Collaborator

@lyrm lyrm commented Jun 14, 2022

This PR :

  • organizes test directory in sub-directories so each (future) data structure has it own test directory,
  • moves the tests for ws_deque from multicoretests repo to here.

@jmid
Copy link
Contributor

jmid commented Jun 15, 2022

I am (not surprisingly) supportive of moving the relevant multicoretests of lockfree here! 😃

However I think it may be a bit too premature to do so ATM.
For one, just yesterday I was wrapping up a QCheck PR c-cube/qcheck#244 for Test.make_neg which will eliminate the clunky check_error_count and simplify the dune files (see ocaml-multicore/multicoretests#78).
For another, I am still not happy with the amount of code required for situations such as this that require

  • different cmd generators
  • more than two parallel domains.

Unfortunately I haven't gotten around to improve the situation (yet) 🤷‍♂️ 😬

@lyrm
Copy link
Collaborator Author

lyrm commented Jun 15, 2022

@jmid : Thanks and sorry, I should have tagged you in my first message.

I totally can see your point, but in an other hand, it feels quite weird to have such important tests in another repository. But for now, I can cancel this PR, and make one for the lf_queue tests in multicoretests (I was planning to make another PR here with lf_queue and its tests after this one have been merged).

@lyrm lyrm marked this pull request as draft November 17, 2022 23:29
@lyrm
Copy link
Collaborator Author

lyrm commented Dec 14, 2022

Replaced by #43 .

@lyrm lyrm closed this Dec 14, 2022
@lyrm lyrm deleted the multicoretests branch January 17, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants