Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCaml 4.14 #119

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Add support for OCaml 4.14 #119

merged 4 commits into from
Dec 2, 2021

Conversation

kit-ty-kate
Copy link
Contributor

No description provided.

kit-ty-kate added a commit to kit-ty-kate/ppxlib that referenced this pull request Nov 16, 2021
…aml-migrate-parsetree (ocaml-ppx/ocaml-migrate-parsetree#119)

Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
Copy link
Member

@pitag-ha pitag-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for picking up the branch, bumping the magic number and running the health checks! The only reason it isn't passing the CI is that I haven't fixed gencopy for >=4.13 yet (so unrelated to this PR). Has this already passed the health check?

Signed-off-by: Kate <kit.ty.kate@disroot.org>
@kit-ty-kate
Copy link
Contributor Author

Has this already passed the health check?

Now yes. It seems to be good to merge as soon as CI passes.

kit-ty-kate added a commit to kit-ty-kate/ppxlib that referenced this pull request Dec 1, 2021
…aml-migrate-parsetree (ocaml-ppx/ocaml-migrate-parsetree#119)

Signed-off-by: Kate <kit.ty.kate@disroot.org>
Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
Signed-off-by: Sonja Heinze <sonjaleaheinze@gmail.com>
pitag-ha added a commit to ocaml-ppx/ppxlib that referenced this pull request Dec 2, 2021
* [1/4] OCaml 4.14 support: Copy OCaml 4.14 ast migration files from ocaml-migrate-parsetree (ocaml-ppx/ocaml-migrate-parsetree#119)

Signed-off-by: Kate <kit.ty.kate@disroot.org>
Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>

* [2/3] OCaml 4.14 support: dune build @cinaps

Signed-off-by: Kate <kit.ty.kate@disroot.org>

* [3/3] OCaml 4.14 support: Translate ocaml-migrate-parsetree specific constructs to ppxlib

Signed-off-by: Kate <kit.ty.kate@disroot.org>

* dune build @fmt

Signed-off-by: Kate <kit.ty.kate@disroot.org>

* Update changelog

Signed-off-by: Kate <kit.ty.kate@disroot.org>

Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
@pitag-ha pitag-ha merged commit af122c4 into ocaml-ppx:master Dec 2, 2021
pitag-ha added a commit to pitag-ha/opam-repository that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants