-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCaml 4.14 #119
Conversation
…l-bench/sandmark#251) Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
…aml-migrate-parsetree (ocaml-ppx/ocaml-migrate-parsetree#119) Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for picking up the branch, bumping the magic number and running the health checks! The only reason it isn't passing the CI is that I haven't fixed gencopy for >=4.13 yet (so unrelated to this PR). Has this already passed the health check?
Signed-off-by: Kate <kit.ty.kate@disroot.org>
Now yes. It seems to be good to merge as soon as CI passes. |
…aml-migrate-parsetree (ocaml-ppx/ocaml-migrate-parsetree#119) Signed-off-by: Kate <kit.ty.kate@disroot.org> Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
Signed-off-by: Sonja Heinze <sonjaleaheinze@gmail.com>
* [1/4] OCaml 4.14 support: Copy OCaml 4.14 ast migration files from ocaml-migrate-parsetree (ocaml-ppx/ocaml-migrate-parsetree#119) Signed-off-by: Kate <kit.ty.kate@disroot.org> Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com> * [2/3] OCaml 4.14 support: dune build @cinaps Signed-off-by: Kate <kit.ty.kate@disroot.org> * [3/3] OCaml 4.14 support: Translate ocaml-migrate-parsetree specific constructs to ppxlib Signed-off-by: Kate <kit.ty.kate@disroot.org> * dune build @fmt Signed-off-by: Kate <kit.ty.kate@disroot.org> * Update changelog Signed-off-by: Kate <kit.ty.kate@disroot.org> Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
CHANGES: - Add support for 4.14 (ocaml-ppx/ocaml-migrate-parsetree#119, @kit-ty-kate)
No description provided.