-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml 4.14 support #304
Merged
Merged
OCaml 4.14 support #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
requested review from
ceastlund,
NathanReb and
pitag-ha
as code owners
November 16, 2021 21:24
pitag-ha
reviewed
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for adapting this to ppxlib and running the health checks! Would you mind running ocamlformat, writing a changelog entry and signing the commits?
…aml-migrate-parsetree (ocaml-ppx/ocaml-migrate-parsetree#119) Signed-off-by: Kate <kit.ty.kate@disroot.org> Co-authored-by: Sonja Heinze <sonjaleaheinze@gmail.com>
Signed-off-by: Kate <kit.ty.kate@disroot.org>
…constructs to ppxlib Signed-off-by: Kate <kit.ty.kate@disroot.org>
Signed-off-by: Kate <kit.ty.kate@disroot.org>
Signed-off-by: Kate <kit.ty.kate@disroot.org>
kit-ty-kate
added a commit
to kit-ty-kate/ppxlib
that referenced
this pull request
Dec 2, 2021
kit-ty-kate
added a commit
to kit-ty-kate/ppxlib
that referenced
this pull request
Dec 3, 2021
Signed-off-by: Kate <kit.ty.kate@disroot.org>
pitag-ha
pushed a commit
that referenced
this pull request
Dec 3, 2021
pitag-ha
added a commit
to pitag-ha/opam-repository
that referenced
this pull request
Dec 8, 2021
CHANGES: - Add support for OCaml 4.14 (ocaml-ppx/ppxlib#304, @kit-ty-kate) - Expand nodes before applying derivers or other inline attributes based transformation, allowing better interactions between extensions and derivers (ocaml-ppx/ppxlib#279, ocaml-ppx/ppxlib#297, @NathanReb) - Add support for registering ppx_import as a pseudo context-free rule (ocaml-ppx/ppxlib#271, @NathanReb) - Add `input_name` to the `Expansion_context.Extension` and `Expansion_context.Deriver` modules (ocaml-ppx/ppxlib#284, @tatchi) - Improve `gen_symbol` to strip previous unique suffix before adding a new one (ocaml-ppx/ppxlib#285, @ceastlund) - Improve `name_type_params_in_td` to use prefixes `a`, `b`, ... instead of `v_x`. (ocaml-ppx/ppxlib#285, @ceastlund) - Fix a bug in `type_is_recursive` and `really_recursive` where they would consider a type declaration recursive if the type appeared inside an attribute payload (ocaml-ppx/ppxlib#299, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors ocaml-ppx/ocaml-migrate-parsetree#119