Expand structure and signature items before applying attribute rules #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
force-pushed
the
expand-before-deriving
branch
from
d2d5dd4 to
ce0183a
Compare
kit-ty-kate
approved these changes
Sep 10, 2021
NathanReb
force-pushed
the
expand-before-deriving
branch
from
ce0183a to
53adb13
Compare
|
I updated the internal documentation and the tests description to reflect this change. I think this should be ready for review now. @jeremiedimino @ceastlund, I don't really expect anything to break here but it might be good to test this change inside JS' monorepo. What do you think? |
NathanReb
force-pushed
the
expand-before-deriving
branch
from
53adb13 to
330744e
Compare
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
expand-before-deriving
branch
from
330744e to
eadedc8
Compare
|
Rebased on top of (formatted!) main and fixed the bug found by @pitag-ha where I forgot to remove a |
5 tasks
pitag-ha
approved these changes
Sep 13, 2021
pitag-ha
added a commit
to pitag-ha/opam-repository
that referenced
this pull request
Dec 8, 2021
CHANGES: - Add support for OCaml 4.14 (ocaml-ppx/ppxlib#304, @kit-ty-kate) - Expand nodes before applying derivers or other inline attributes based transformation, allowing better interactions between extensions and derivers (ocaml-ppx/ppxlib#279, ocaml-ppx/ppxlib#297, @NathanReb) - Add support for registering ppx_import as a pseudo context-free rule (ocaml-ppx/ppxlib#271, @NathanReb) - Add `input_name` to the `Expansion_context.Extension` and `Expansion_context.Deriver` modules (ocaml-ppx/ppxlib#284, @tatchi) - Improve `gen_symbol` to strip previous unique suffix before adding a new one (ocaml-ppx/ppxlib#285, @ceastlund) - Improve `name_type_params_in_td` to use prefixes `a`, `b`, ... instead of `v_x`. (ocaml-ppx/ppxlib#285, @ceastlund) - Fix a bug in `type_is_recursive` and `really_recursive` where they would consider a type declaration recursive if the type appeared inside an attribute payload (ocaml-ppx/ppxlib#299, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the order in which context-free rules are applied.
It is a follow up to #276 and "fixes" the behaviour observed there. With this PR a node with attributes attached will be first expanded and then the inline attribute rules applied instead of the other way around.
Imagine the following:
Before this PR, the
some_derivertransformation would be applied first, now it is applied to the result of the expansion of the type declaration, meaning after thesome_exttransformation was applied.@kit-ty-kate is gracefully testing this on the opam universe to see if it has any serious impact. I don't expect anyone to rely on this behaviour but better be safe than sorry.
Edit: You might want to review this while hiding whitespace diffs as a whole block in
Context_freehas gained one level of identation without any further change.