Fix type_is_recursive and really_recursive
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
force-pushed
the
fix-type-is-rec
branch
2 times, most recently
from
41e3cb1 to
b335ff2
Compare
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Those used to recurse into attributes, sometimes falsly returning `Recursive`. Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
fix-type-is-rec
branch
from
b335ff2 to
7f04dd6
Compare
|
It is indeed a broader bug. @ceastlund will confirm but I think it's discovery is related to the change in application order, i.e. the fact that deriver now receive the expanded node. It seems some ppx used at Janestreet will add attributes that weren't visible by the derivers before. Since those derivers use #297 made discovering this possible because before it, the builds would fail at earlier stages, before the ppx-es were all applied. |
pitag-ha
added a commit
to pitag-ha/opam-repository
that referenced
this pull request
Dec 8, 2021
CHANGES: - Add support for OCaml 4.14 (ocaml-ppx/ppxlib#304, @kit-ty-kate) - Expand nodes before applying derivers or other inline attributes based transformation, allowing better interactions between extensions and derivers (ocaml-ppx/ppxlib#279, ocaml-ppx/ppxlib#297, @NathanReb) - Add support for registering ppx_import as a pseudo context-free rule (ocaml-ppx/ppxlib#271, @NathanReb) - Add `input_name` to the `Expansion_context.Extension` and `Expansion_context.Deriver` modules (ocaml-ppx/ppxlib#284, @tatchi) - Improve `gen_symbol` to strip previous unique suffix before adding a new one (ocaml-ppx/ppxlib#285, @ceastlund) - Improve `name_type_params_in_td` to use prefixes `a`, `b`, ... instead of `v_x`. (ocaml-ppx/ppxlib#285, @ceastlund) - Fix a bug in `type_is_recursive` and `really_recursive` where they would consider a type declaration recursive if the type appeared inside an attribute payload (ocaml-ppx/ppxlib#299, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions used to return
Recursiveif the types appeared inside attributes within the type declarations.The bug and the fix were discovered by @ceastlund while trying out #297 on Jane Street's code base.
I split this in two parts: first one adds tests, second one fixes the bug and updates the tests accordingly.
Let me know what you think!