[bug fix] Import module types with optional arguments #37
Conversation
When importing a module type containing a function value taking an optional argument of type `t`, the imported type for the argument was `t option` instead of `t`.
|
Sorry if this isn't the right place to ask, but are there any plans to cut an opam release with this bugfix? Asking because I just ran into precisely this bug myself when using the opam release of |
|
Hi @MattWindsor91 , sure, I'll push a release right now. @whitequark this PR was missing a |
Seems heavy-handed... Not sure what I think about it. |
|
For smaller projects like this one I've been writing release notes myself at release time, mentioning only the PR that were not purely internal (that I thought may affect the users of the software). It's generally 3/4 things to mention each release, so fine. It's less hassle than forcing the users to do this -- of course if users include a Changelog entry in their PR, that's swell too. |
* [new release] ppx_import (1.6.2)
CHANGES:
* Fix import of module types with optional arguments
(Thierry Martinez ocaml-ppx/ppx_import#37, review by whitequark)
* ppx_import.1.6.2: remove redundant fields
* [new release] ppx_import (1.6.2)
CHANGES:
* Fix import of module types with optional arguments
(Thierry Martinez ocaml-ppx/ppx_import#37, review by whitequark)
* ppx_import.1.6.2: remove redundant fields
When importing a module type containing a function value taking an
optional argument of type
t, the imported type for the argument wast optioninstead oft.