[new release] ppx_import (1.6.2) #14296
Merged
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES:
* Fix import of module types with optional arguments
(Thierry Martinez ocaml-ppx/ppx_import#37, review by whitequark)
☀️ All lint checks passed 27b81e7
☀️ Installability check (11224 → 11225)
|
|
The revdeps failures seem unrelated to this. @ejgallego can you also have a look before I merge? |
@mseri they do seem indeed unrelated, the upstream patch is minimal so I dunno how it could break them. |
|
Thanks for looking into it! |
|
Thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A syntax extension for importing declarations from interface files
CHANGES:
(Thierry Martinez [bug fix] Import module types with optional arguments ocaml-ppx/ppx_import#37, review by whitequark)