Do not duplicate profile in missing deps message

Closes #1106 Signed-off-by: Etienne Millon <me@emillon.org>
ocaml · Aug 7, 2018 · c6e58b0 · c6e58b0
1 parent b616c7e
commit c6e58b0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/bin/main.ml b/bin/main.ml
@@ -510,8 +510,7 @@ let common =
   in
   let orig_args =
     List.concat
-      [ dump_opt "--profile" profile
-      ; dump_opt "--workspace" (Option.map ~f:Arg.Path.arg workspace_file)
+      [ dump_opt "--workspace" (Option.map ~f:Arg.Path.arg workspace_file)
       ; orig
       ]
   in

diff --git a/test/blackbox-tests/test-cases/findlib/run.t b/test/blackbox-tests/test-cases/findlib/run.t
@@ -11,3 +11,11 @@ Reproduction case for #484. The error should point to src/jbuild
   Error: Library "a" not found.
   Hint: try: dune external-lib-deps --missing @install
   [1]
+
+When passing --dev, the profile should be displayed only once (#1106):
+
+  $ jbuilder build --dev @install
+  File "src/dune", line 4, characters 14-15:
+  Error: Library "a" not found.
+  Hint: try: dune external-lib-deps --missing --profile dev @install
+  [1]