Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag duplication in external-lib-deps suggestion #1106

Closed
hcarty opened this issue Aug 6, 2018 · 2 comments
Closed

Flag duplication in external-lib-deps suggestion #1106

hcarty opened this issue Aug 6, 2018 · 2 comments
Assignees
@emillon

Comments

@hcarty
Copy link
Member

hcarty commented Aug 6, 2018

When building a project with multiple missing dependencies:

$ jbuilder build --dev
File "src/proxy/jbuild", line 5, characters 20-27:
Error: Library "lwt_ppx" not found.
Hint: try: dune external-lib-deps --missing --profile dev --profile dev @install

--profile dev is listed twice. dune will reject the invocation unless the extra --profile dev is removed.
@emillon emillon self-assigned this Aug 7, 2018
@emillon
Copy link
Collaborator

emillon commented Aug 7, 2018

Thanks for the bug report. I think that we can just remove the profile in that case.

emillon added a commit that referenced this issue Aug 7, 2018
@emillon
Do not duplicate profile in missing deps message
c6e58b0 
Closes #1106

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit that referenced this issue Aug 7, 2018
@emillon
Do not duplicate profile in missing deps message
5802f64 
Closes #1106

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon closed this as completed in f5c45a7 Aug 7, 2018
emillon added a commit that referenced this issue Aug 7, 2018
@emillon
Merge pull request #1109 from ocaml/fix-1106
0f18a6e 
Do not duplicate profile in missing deps message (fixes #1106)
@hcarty
Copy link
Member Author

hcarty commented Aug 7, 2018

Thanks for the quick fix!

rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Aug 8, 2018
@rgrinberg
[new release] dune (1.1.1)
9f1d253 
CHANGES:

- Fix `$ jbuilder --dev` (ocaml/dune#1104, fixes ocaml/dune#1103, @rgrinberg)

- Fix dune exec when `--build-dir` is set to an absolute path (ocaml/dune#1105, fixes
  ocaml/dune#1101, @rgrinberg)

- Fix duplicate profile argument in suggested command when an external library
  is missing (ocaml/dune#1109, ocaml/dune#1106, @emillon)

- `-opaque` wasn't correctly being added to modules without an interface.
  (ocaml/dune#1108, fix ocaml/dune#1107, @rgrinberg)

- Fix validation of library `name` fields and make sure this validation also
  applies when the `name` is derived from the `public_name`. (ocaml/dune#1110, fix ocaml/dune#1102,
  @rgrinberg)

- Fix a bug causing the toplevel `env` stanza in the workspace file to
  be ignored when at least one context had `(merlin)` (ocaml/dune#1114, @diml)
@rgrinberg rgrinberg mentioned this issue Aug 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emillon emillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hcarty @emillon