Missing -opaque when compiling implementation-only modules #1107
Comments
rgrinberg
added a commit
to rgrinberg/jbuilder
that referenced
this issue
Aug 7, 2018
-opaque should be passed for mli only modules or for all modules when opaque mode is on Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
ghost
mentioned this issue
Merged
rgrinberg
added a commit
to rgrinberg/jbuilder
that referenced
this issue
Aug 7, 2018
-opaque should be passed for mli only modules or for all modules when opaque mode is on Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg
added a commit
that referenced
this issue
Aug 7, 2018
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this issue
Aug 8, 2018
CHANGES: - Fix `$ jbuilder --dev` (ocaml/dune#1104, fixes ocaml/dune#1103, @rgrinberg) - Fix dune exec when `--build-dir` is set to an absolute path (ocaml/dune#1105, fixes ocaml/dune#1101, @rgrinberg) - Fix duplicate profile argument in suggested command when an external library is missing (ocaml/dune#1109, ocaml/dune#1106, @emillon) - `-opaque` wasn't correctly being added to modules without an interface. (ocaml/dune#1108, fix ocaml/dune#1107, @rgrinberg) - Fix validation of library `name` fields and make sure this validation also applies when the `name` is derived from the `public_name`. (ocaml/dune#1110, fix ocaml/dune#1102, @rgrinberg) - Fix a bug causing the toplevel `env` stanza in the workspace file to be ignored when at least one context had `(merlin)` (ocaml/dune#1114, @diml)
ghost
mentioned this issue
facebook-github-bot
pushed a commit
to facebook/infer
that referenced
this issue
Aug 21, 2018
Summary: This seems to fix intermittent "Corrupted compilation unit description" failures in the build: ocaml/dune#1157 It also fixes build warnings 58: ocaml/dune#1107 Reviewed By: mbouaziz Differential Revision: D9420579 fbshipit-source-id: d63adee67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that the test for when to add the
-opaqueoption only triggers when compiling interfaces. For modules with only an implementation, this seems to result in a .cmi that is produced without-opaque, leading to warning 58 firing on its clients that do have interfaces.This can be seen with
make devof a wip branch of ocamlformat.The text was updated successfully, but these errors were encountered: