Fix #1107 #1108
Merged
Fix #1107 #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Aug 7, 2018
src/module_compilation.ml
Outdated
| let intf_only = (* we add opaque even outside "dev" for mli only *) | ||
| cm_kind = Cmi | ||
| && not (Module.has_impl m) | ||
| && Ocaml_version.supports_opaque_for_mli ctx.version |
There was a problem hiding this comment.
It feel a bit odd that supports_opaque_for_mli is connected to the module being intf_only. It would seem clearer to me to write:
if opaque || (intf_only && Ocaml_version.supports_opaque_for_mli ctx.version) then
There was a problem hiding this comment.
Yeah, I think that would be better as well.
|
This change look good, but #1107 is about implementation only modules. I believe the flags for these latter ones are unchanged by this PR. |
How so? I think such modules would fall under |
ghost
approved these changes
Aug 7, 2018
|
Ah, yes you are right |
-opaque should be passed for mli only modules or for all modules when opaque mode is on Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Aug 8, 2018
CHANGES: - Fix `$ jbuilder --dev` (ocaml/dune#1104, fixes ocaml/dune#1103, @rgrinberg) - Fix dune exec when `--build-dir` is set to an absolute path (ocaml/dune#1105, fixes ocaml/dune#1101, @rgrinberg) - Fix duplicate profile argument in suggested command when an external library is missing (ocaml/dune#1109, ocaml/dune#1106, @emillon) - `-opaque` wasn't correctly being added to modules without an interface. (ocaml/dune#1108, fix ocaml/dune#1107, @rgrinberg) - Fix validation of library `name` fields and make sure this validation also applies when the `name` is derived from the `public_name`. (ocaml/dune#1110, fix ocaml/dune#1102, @rgrinberg) - Fix a bug causing the toplevel `env` stanza in the workspace file to be ignored when at least one context had `(merlin)` (ocaml/dune#1114, @diml)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-opaque should be passed for mli only modules or for all modules when opaque
mode is on
This is overdoing the opaque mode a bit. As we don't really need to pass it when creating cmo/cmx files for which the cmi exists, but it seems like it doesn't do any harm.