Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'dune exec' behaves differently with DUNE_BUILD_DIR set to absolute path #1101

Closed
andreypopp opened this issue Aug 6, 2018 · 1 comment
Closed

Comments

@andreypopp
Copy link
Member

If I try to set DUNE_BUILD_DIR to an absolute path dune exec fails:

% DUNE_BUILD_DIR="$PWD/_custom" dune exec test/test_main.exe
File unavailable: /Users/andreypopp/Workspace/esy-ocaml/repromise/_custom/default/test/test_main.exe

while relative DUNE_BUILD_DIR (or an absence of such) works:

% dune exec test/test_main.exe
Testing library 'repromise'...
......................................................
Ok. 54 tests ran, 0 tests skipped
% DUNE_BUILD_DIR="./_custom" dune exec test/test_main.exe
Testing library 'repromise'...
......................................................
Ok. 54 tests ran, 0 tests skipped

Hitting this with esy on aantron/repromise but the snippets above are replicated with opam.

rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Aug 6, 2018
Do not attempt to convert string -> path -> string as this loses information

Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg added a commit that referenced this issue Aug 7, 2018
@andreypopp
Copy link
Member Author

Thank you!

rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Aug 8, 2018
CHANGES:

- Fix `$ jbuilder --dev` (ocaml/dune#1104, fixes ocaml/dune#1103, @rgrinberg)

- Fix dune exec when `--build-dir` is set to an absolute path (ocaml/dune#1105, fixes
  ocaml/dune#1101, @rgrinberg)

- Fix duplicate profile argument in suggested command when an external library
  is missing (ocaml/dune#1109, ocaml/dune#1106, @emillon)

- `-opaque` wasn't correctly being added to modules without an interface.
  (ocaml/dune#1108, fix ocaml/dune#1107, @rgrinberg)

- Fix validation of library `name` fields and make sure this validation also
  applies when the `name` is derived from the `public_name`. (ocaml/dune#1110, fix ocaml/dune#1102,
  @rgrinberg)

- Fix a bug causing the toplevel `env` stanza in the workspace file to
  be ignored when at least one context had `(merlin)` (ocaml/dune#1114, @diml)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant