Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Error: CreateProcess(): No such file or directory when PATH contains unicode characters #10180

Closed
kit-ty-kate opened this issue Mar 1, 2024 · 2 comments · Fixed by janestreet/spawn#58 or #10212
Closed

Windows: Error: CreateProcess(): No such file or directory when PATH contains unicode characters #10180

kit-ty-kate opened this issue Mar 1, 2024 · 2 comments · Fixed by janestreet/spawn#58 or #10212
Labels
bug windows

Comments

@kit-ty-kate
Copy link
Member

This is all explained in janestreet/spawn#57

Specifications

  • Version of dune (output of dune --version): 3.5.0 (but the same code is used in the latest version)
  • Operating system (distribution and version): Windows (using Cygwin Terminal but it shouldn't matter)
@kit-ty-kate kit-ty-kate mentioned this issue Mar 1, 2024
Closed
@emillon emillon mentioned this issue Mar 4, 2024
Closed
15 tasks
@dra27
Copy link
Member

dra27 commented Mar 4, 2024

Just noting here too that I have a fix for the issue in spawn - is it OK to open PRs simultaneously against spawn and Dune or should the spawn one go in first and then update the vendored sources in Dune?

@emillon
Copy link
Collaborator

emillon commented Mar 4, 2024

Once you have opened the PR against upstream spawn, you can post the link here and I'll update the repo we use to vendor patches.

@dra27 dra27 mentioned this issue Mar 5, 2024
Merged
emillon added a commit to emillon/dune that referenced this issue Mar 5, 2024
@emillon
fix(windows): use unicode version of CreateProcess
c7179fd 
This updates our spawn vendored version to include janestreet/spawn#58.

Fixes ocaml#10180

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon mentioned this issue Mar 5, 2024
Merged
emillon added a commit to emillon/dune that referenced this issue Mar 5, 2024
@emillon
fix(windows): use unicode version of CreateProcess
3c6ee60 
This updates our spawn vendored version to include janestreet/spawn#58.

Fixes ocaml#10180

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this issue Mar 5, 2024
@emillon
fix(windows): use unicode version of CreateProcess
8e832a3 
This updates our spawn vendored version to include janestreet/spawn#58.

Fixes ocaml#10180

Signed-off-by: Etienne Millon <me@emillon.org>
@rgrinberg rgrinberg reopened this Mar 9, 2024
emillon added a commit to emillon/dune that referenced this issue Mar 11, 2024
@emillon
fix(windows): use unicode version of CreateProcess
9faef00 
This does several things:
- update our spawn vendored version to include janestreet/spawn#58
- pick the dune file
- add new build flags for bootstrapping

Fixes ocaml#10180

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this issue Mar 11, 2024
@emillon
fix(windows): use unicode version of CreateProcess
7fb6e28 
This does several things:
- update our spawn vendored version to include janestreet/spawn#58
- pick the dune file
- add new build flags for bootstrapping

Fixes ocaml#10180

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this issue Mar 11, 2024
@emillon
fix(windows): use unicode version of CreateProcess
09c6e8e 
This does several things:
- update our spawn vendored version to include janestreet/spawn#58
- pick the dune file
- add new build flags for bootstrapping

Fixes ocaml#10180

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit that referenced this issue Mar 11, 2024
@emillon
fix(windows): use unicode version of CreateProcess (#10212)
6c40cb1 
This does several things:
- update our spawn vendored version to include janestreet/spawn#58
- pick the dune file
- add new build flags for bootstrapping

Fixes #10180

Signed-off-by: Etienne Millon <me@emillon.org>
Leonidas-from-XIV pushed a commit to Leonidas-from-XIV/dune that referenced this issue Mar 11, 2024
@emillon @Leonidas-from-XIV
fix(windows): use unicode version of CreateProcess (ocaml#10212)
c33e32d 
This does several things:
- update our spawn vendored version to include janestreet/spawn#58
- pick the dune file
- add new build flags for bootstrapping

Fixes ocaml#10180

Signed-off-by: Etienne Millon <me@emillon.org>
Leonidas-from-XIV added a commit that referenced this issue Mar 11, 2024
@Leonidas-from-XIV @emillon
fix(windows): use unicode version of CreateProcess (#10212) (#10246)
220d32f 
This does several things:
- update our spawn vendored version to include janestreet/spawn#58
- pick the dune file
- add new build flags for bootstrapping

Fixes #10180

Signed-off-by: Etienne Millon <me@emillon.org>
Co-authored-by: Etienne Millon <me@emillon.org>
@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Mar 11, 2024
Closed
Leonidas-from-XIV added a commit to Leonidas-from-XIV/opam-repository that referenced this issue Mar 11, 2024
@Leonidas-from-XIV
[new release] dune (15 packages) (3.14.1)
8ea501e 
CHANGES:

### Fixed

- When a directory is changed to a file, correctly remove it in subsequent
  `dune build` runs. (ocaml/dune#9327, fix ocaml/dune#6575, @emillon)

- Fix a problem with the doc-new target where transitive dependencies were
  missed during compile. This leads to missing expansions in the output docs.
  (ocaml/dune#9955, @jonludlam)

- coq: fix performance regression in coqdep unescaping (ocaml/dune#10115, fixes ocaml/dune#10088,
  @ejgallego, thanks to Dan Christensen for the report)

- coq: memoize coqdep parsing, this will reduce build times for Coq users, in
  particular for those with many .v files (ocaml/dune#10116, @ejgallego, see also ocaml/dune#10088)

- on Windows, use an unicode-aware version of `CreateProcess` to avoid crashes
  when paths contains non-ascii characters. (ocaml/dune#10212, fixes ocaml/dune#10180, @emillon)
@emillon emillon mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug windows
Projects
None yet
Milestone
No milestone
4 participants
@rgrinberg @emillon @kit-ty-kate @dra27