Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune (15 packages) (3.14.1) #25456

Closed

Conversation

Leonidas-from-XIV
Copy link
Contributor

Fast, portable, and opinionated build system

CHANGES:

Fixed

CHANGES:

### Fixed

- When a directory is changed to a file, correctly remove it in subsequent
  `dune build` runs. (ocaml/dune#9327, fix ocaml/dune#6575, @emillon)

- Fix a problem with the doc-new target where transitive dependencies were
  missed during compile. This leads to missing expansions in the output docs.
  (ocaml/dune#9955, @jonludlam)

- coq: fix performance regression in coqdep unescaping (ocaml/dune#10115, fixes ocaml/dune#10088,
  @ejgallego, thanks to Dan Christensen for the report)

- coq: memoize coqdep parsing, this will reduce build times for Coq users, in
  particular for those with many .v files (ocaml/dune#10116, @ejgallego, see also ocaml/dune#10088)

- on Windows, use an unicode-aware version of `CreateProcess` to avoid crashes
  when paths contains non-ascii characters. (ocaml/dune#10212, fixes ocaml/dune#10180, @emillon)
@emillon
Copy link
Contributor

emillon commented Mar 11, 2024

this release doesn't work on alpine, we'll push a fix in 3.14.2. we can leave CI run on this one, but I'm not sure what's best for 3.14.1 after. We can either not merge it, make it available: false or unavailable on alpine. I'll let the opam-repository maintainers decide.

@Leonidas-from-XIV Leonidas-from-XIV marked this pull request as draft March 11, 2024 17:34
@Leonidas-from-XIV
Copy link
Contributor Author

Switching it to draft in the meantime to signal it shouldn't be merged as-is.

@Leonidas-from-XIV
Copy link
Contributor Author

To add to @emillon's comment: I am pretty sure it doesn't work on any musl-based systems nor does it work on FreeBSD according to CI (for the same reason), so it is more dependent on the libc than the OS which makes it hard to exclude specific OSes.

@emillon
Copy link
Contributor

emillon commented Mar 12, 2024

One regression here, the musl one. It's being fixed in an upcoming 3.14.2.
Opam-repository maintainers, what do you want to do with 3.14.1? Should we merge it as available: false or close this PR?

@Leonidas-from-XIV
Copy link
Contributor Author

#25474 created which comes with a fix for this regression.

@Leonidas-from-XIV Leonidas-from-XIV marked this pull request as ready for review March 14, 2024 16:45
@mseri
Copy link
Member

mseri commented Mar 15, 2024

I think it is easier to just close this PR since 3.14.2 is already released and this would be unavailable anyway

@mseri mseri closed this Mar 15, 2024
@Leonidas-from-XIV Leonidas-from-XIV deleted the release-dune-3.14.1 branch March 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants