Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(wrapped (transition ...)) doesn't set flags correctly #1364

Closed
ejgallego opened this issue Oct 1, 2018 · 0 comments · Fixed by ocaml/opam-repository#12774
Closed

(wrapped (transition ...)) doesn't set flags correctly #1364

ejgallego opened this issue Oct 1, 2018 · 0 comments · Fixed by ocaml/opam-repository#12774
Assignees
@rgrinberg

Comments

@ejgallego
Copy link
Collaborator

Example:

(library
 (name foo)
 (public_name bug.foo)
 (flags :standard -rectypes)
 (wrapped (transition "hi")))

results in

      ocamlc .foo.objs/k.{cmi,cmo,cmt} (exit 2)
(cd _build/default && /home/egallego/.opam/4.07.0/bin/ocamlc.opt -w @a-4-29-40-41-42-44-45-48-58-59-60-40 -strict-sequence -strict-formats -short-paths -keep-locs -g -bin-annot -I .foo.objs -I .foo.objs/.private -no-alias-deps -opaque -o .foo.objs/k.cmo -c -impl .wrapped_compat/K.ml-gen)
File ".wrapped_compat/K.ml-gen", line 1:
Error: Unit K imports from Foo__K, which uses recursive types.
       The compilation flag -rectypes is required
@rgrinberg rgrinberg self-assigned this Oct 2, 2018
rgrinberg added a commit to rgrinberg/jbuilder that referenced this issue Oct 2, 2018
@rgrinberg
Do not reset flags for compatibility modules
43694a4 
Fix ocaml#1364

Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
@rgrinberg rgrinberg mentioned this issue Oct 2, 2018
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Oct 4, 2018
@rgrinberg
[new release] dune (1.4.0)
f5fc609 
CHANGES:

- Do not fail if the output of `ocamlc -config` doesn't include
  `standard_runtime` (ocaml/dune#1326, @diml)

- Let `Configurator.V1.C_define.import` handle negative integers
  (ocaml/dune#1334, @Chris00)

- Re-execute actions when a target is modified by the user inside
  `_build` (ocaml/dune#1343, fix ocaml/dune#1342, @diml)

- Pass `--set-switch` to opam (ocaml/dune#1341, fix ocaml/dune#1337, @diml)

- Fix bad interaction between multi-directory libraries the `menhir`
  stanza (ocaml/dune#1373, fix ocaml/dune#1372, @diml)

- Integration with automatic formatters (ocaml/dune#1252, fix ocaml/dune#1201, @emillon)

- Better error message when using `(self_build_stubs_archive ...)` and
  `(c_names ...)` or `(cxx_names ...)` simultaneously.
  (ocaml/dune#1375, fix ocaml/dune#1306, @nojb)

- Improve name detection for packages when the prefix isn't an actual package
  (ocaml/dune#1361, fix ocaml/dune#1360, @rgrinberg)

- Support for new menhir rules (ocaml/dune#863, fix ocaml/dune#305, @fpottier, @rgrinberg)

- Do not remove flags when compiling compatibility modules for wrapped mode
  (ocaml/dune#1382, fix ocaml/dune#1364, @rgrinberg)

- Fix reason support when using `staged_pps` (ocaml/dune#1384, @charlesetc)

- Add support for `enabled_if` in `rule`, `menhir`, `ocamllex`,
  `ocamlyacc` (ocaml/dune#1387, @diml)

- Exit gracefully when a signal is received (ocaml/dune#1366, @diml)

- Load all defined libraries recursively into utop (ocaml/dune#1384, fix ocaml/dune#1344,
  @rgrinberg)

- Allow to use libraries `bytes`, `result` and `uchar` without `findlib`
  installed (ocaml/dune#1391, @nojb)
@rgrinberg rgrinberg mentioned this issue Oct 4, 2018
Closed
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Oct 10, 2018
@rgrinberg
[new release] dune (1.4.0)
9e08c98 
CHANGES:

- Do not fail if the output of `ocamlc -config` doesn't include
  `standard_runtime` (ocaml/dune#1326, @diml)

- Let `Configurator.V1.C_define.import` handle negative integers
  (ocaml/dune#1334, @Chris00)

- Re-execute actions when a target is modified by the user inside
  `_build` (ocaml/dune#1343, fix ocaml/dune#1342, @diml)

- Pass `--set-switch` to opam (ocaml/dune#1341, fix ocaml/dune#1337, @diml)

- Fix bad interaction between multi-directory libraries the `menhir`
  stanza (ocaml/dune#1373, fix ocaml/dune#1372, @diml)

- Integration with automatic formatters (ocaml/dune#1252, fix ocaml/dune#1201, @emillon)

- Better error message when using `(self_build_stubs_archive ...)` and
  `(c_names ...)` or `(cxx_names ...)` simultaneously.
  (ocaml/dune#1375, fix ocaml/dune#1306, @nojb)

- Improve name detection for packages when the prefix isn't an actual package
  (ocaml/dune#1361, fix ocaml/dune#1360, @rgrinberg)

- Support for new menhir rules (ocaml/dune#863, fix ocaml/dune#305, @fpottier, @rgrinberg)

- Do not remove flags when compiling compatibility modules for wrapped mode
  (ocaml/dune#1382, fix ocaml/dune#1364, @rgrinberg)

- Fix reason support when using `staged_pps` (ocaml/dune#1384, @charlesetc)

- Add support for `enabled_if` in `rule`, `menhir`, `ocamllex`,
  `ocamlyacc` (ocaml/dune#1387, @diml)

- Exit gracefully when a signal is received (ocaml/dune#1366, @diml)

- Load all defined libraries recursively into utop (ocaml/dune#1384, fix ocaml/dune#1344,
  @rgrinberg)

- Allow to use libraries `bytes`, `result` and `uchar` without `findlib`
  installed (ocaml/dune#1391, @nojb)

- Take argument to self_build_stubs_archive into account. (ocaml/dune#1395, @nojb)

- Fix bad interaction between `env` customization and vendored
  projects: when a vendored project didn't have its own `env` stanza,
  the `env` stanza from the enclosing project was in effect (ocaml/dune#1408,
  @diml)

- Fix stop early bug when scanning for watermarks (ocaml/dune#1423, @diml)
@rgrinberg rgrinberg mentioned this issue Oct 10, 2018
Merged
shonfeder pushed a commit to shonfeder/dune that referenced this issue Dec 31, 2018
@rgrinberg @shonfeder
Do not reset flags for compatibility modules
c5ec37d 
Fix ocaml#1364

Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrinberg rgrinberg

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rgrinberg @ejgallego