You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, Dune is hardcoded to assume that the only static file generated by odoc is odoc.css. However, odoc is now also generating highlight.pack.js.
As a consequence, Dune deletes highlight.pack.js on the first rebuild of docs during directory cleanup, and does not have odoc re-generate it (which Dune wouldn't do anyway, if it expected odoc to generate the file in the first place). So, after a rebuild, highlight.pack.js is missing.
Since the set of files odoc generates is likely to change over time, odoc is adding an odoc support-files-targets command (ocaml/odoc#232). Dune should use this during docs builds. We'll probably need to add a conflict with versions of odoc that don't have support-files-targets (<= 1.3.0).
Since this requires running the odoc binary to assemble build rules, it complicates builds in which odoc itself is also being built.
The issue with highlight.pack.js was originally reported in ocaml/odoc#153.
The text was updated successfully, but these errors were encountered:
In the meantime, what about we simply add highlight.pack.js as a static target, and add a conflicts with versions of odoc that don't generate this file?
Currently, Dune is hardcoded to assume that the only static file generated by odoc is
odoc.css
. However, odoc is now also generatinghighlight.pack.js
.As a consequence, Dune deletes
highlight.pack.js
on the first rebuild of docs during directory cleanup, and does not have odoc re-generate it (which Dune wouldn't do anyway, if it expected odoc to generate the file in the first place). So, after a rebuild,highlight.pack.js
is missing.Since the set of files odoc generates is likely to change over time, odoc is adding an
odoc support-files-targets
command (ocaml/odoc#232). Dune should use this during docs builds. We'll probably need to add a conflict with versions of odoc that don't havesupport-files-targets
(<= 1.3.0
).Since this requires running the
odoc
binary to assemble build rules, it complicates builds in whichodoc
itself is also being built.The issue with
highlight.pack.js
was originally reported in ocaml/odoc#153.The text was updated successfully, but these errors were encountered: