Math support files #899
Merged
Math support files #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
approved these changes
Oct 20, 2022
src/vendor/dune
Outdated
| (setenv | ||
| SOURCE_DATE_EPOCH | ||
| 0 | ||
| (run ocaml-crunch . -e js -e css -e woff2 -o %{x}.corrected -m plain)) |
There was a problem hiding this comment.
This prints something, which is not useful to know given how fast it runs.
Suggested change
| (run ocaml-crunch . -e js -e css -e woff2 -o %{x}.corrected -m plain)) | |
| (run ocaml-crunch . -e js -e css -e woff2 -o %{x}.corrected -m plain -s)) |
There was a problem hiding this comment.
Just tried this, but -s doesn't work on older crunches, so I'll revert.
There was a problem hiding this comment.
Well older crunches produce different output anyway, so that's not much help.
jonludlam
force-pushed
the
math-support-files
branch
from
aa6734b
to
fdf8d5f
Compare
This isn't quite the right test, it should be on the version of ocaml-crunch, but right now it has the behaviour we want.
jonludlam
force-pushed
the
math-support-files
branch
from
2844752
to
dd29842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math support currently doesn't work because
odoc support-filesdoesn't actually write the vendored katex files. This PR fixes that.Note that dune doesn't quite work yet with this as it's only expecting the original 2 files to be output, and while it will work with the first build, rebuilds don't work as expected. This is related to ocaml/dune#1556.