Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"dune top" output does not property escape strings #4231

Closed
nojb opened this issue Feb 15, 2021 · 1 comment · Fixed by #4242
Closed

"dune top" output does not property escape strings #4231

nojb opened this issue Feb 15, 2021 · 1 comment · Fixed by #4242
Labels
bug

Comments

@nojb
Copy link
Collaborator

nojb commented Feb 15, 2021

eg:

$ cat mlfip.mltop
#directory "c:\cygwin64\home\nojebar\mlfi2\_build/default/applications/csharp_interface/.interfaces.objs/byte";;
#directory "c:\cygwin64\home\nojebar\mlfi2\_build/default/applications/csharp_interface/.interfaces.objs/native";;
#directory "c:\cygwin64\home\nojebar\mlfi2\_build/default/applications/csml/.csml_standalone.objs/byte";;
#directory "c:\cygwin64\home\nojebar\mlfi2\_build/default/applications/csml/.csml_standalone.objs/native";;
#directory "c:\cygwin64\home\nojebar\mlfi2\_build/default/private/a1a3_migration/.a1a3_migration.objs/native";;
#directory "c:\cygwin64\home\nojebar\mlfi2\_build/default/private/a1a3_migration/.a1a3_migration.objs/public_cmi";;
@nojb nojb changed the title dune top output does not property escape strings "dune top" output does not property escape strings Feb 15, 2021
@ghost ghost added the bug label Feb 15, 2021
@ghost
Copy link

ghost commented Feb 15, 2021

That doesn't seem right indeed

@nojb nojb mentioned this issue Feb 17, 2021
Merged
@nojb nojb closed this as completed in #4242 Mar 5, 2021
@rgrinberg rgrinberg mentioned this issue Mar 7, 2021
Closed
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Mar 7, 2021
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-site, du…
26052da 
…ne-action-plugin, dune-private-libs and dune-glob (2.8.3)

CHANGES:

- Make `patdiff` show refined diffs (ocaml/dune#4257, fixes ocaml/dune#4254, @hakuch)

- Fixed a bug that could result in needless recompilation under Windows due to
  case differences in the result of `Sys.getcwd` (observed under `emacs`).
  (ocaml/dune#3966, @nojb).

- Restore compatibility with Coq < 8.10 for coq-lang < 0.3 , document
  that `(using coq 0.3)` does require Coq 8.10 at least (ocaml/dune#4224, fixes
  ocaml/dune#4142, @ejgallego)

- Add a META rule for 'compiler-libs.native-toplevel' (ocaml/dune#4175, @AltGr)

- No longer call `chmod` on symbolic links (fixes ocaml/dune#4195, @dannywillems)

- Dune no longer automatically create or edit `dune-project` files
  (ocaml/dune#4239, fixes ocaml/dune#4108, @jeremiedimino)

- Have `dune` communicate the location of the standard library directory to
  `merlin` (ocaml/dune#4211, fixes ocaml/dune#4188, @nojb)

- Workaround incorrect exception raised by Unix.utimes (OCaml PR#8857) in
  Path.touch on Windows (ocaml/dune#4223, @dra27)

- `dune ocaml-merlin` is now able to provide configuration for source files in
  the `_build` directory. (ocaml/dune#4274, @voodoos)

- Automatically delete left-over Merlin files when rebuilding for the first time
  a project previously built with Dune `<= 2.7`. (ocaml/dune#4261, @voodoos, @aalekseyev)

- Fix `ppx.exe` being compiled for the wrong target when cross-compiling
  (ocaml/dune#3751, fixes ocaml/dune#3698, @toots)

- `dune top` correctly escapes the generated toplevel directives, and make it
  easier for `dune top` to locate C stubs associated to concerned libraries.
  (ocaml/dune#4242, fixes ocaml/dune#4231, @nojb)

- Do not pass include directories containing native objects when compiling
  bytecode (ocaml/dune#4200, @nojb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@nojb