-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] dune-build-info, dune, dune-configurator, dune-site, dune-action-plugin, dune-private-libs and dune-glob (2.8.3) #18286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne-action-plugin, dune-private-libs and dune-glob (2.8.3) CHANGES: - Make `patdiff` show refined diffs (ocaml/dune#4257, fixes ocaml/dune#4254, @hakuch) - Fixed a bug that could result in needless recompilation under Windows due to case differences in the result of `Sys.getcwd` (observed under `emacs`). (ocaml/dune#3966, @nojb). - Restore compatibility with Coq < 8.10 for coq-lang < 0.3 , document that `(using coq 0.3)` does require Coq 8.10 at least (ocaml/dune#4224, fixes ocaml/dune#4142, @ejgallego) - Add a META rule for 'compiler-libs.native-toplevel' (ocaml/dune#4175, @AltGr) - No longer call `chmod` on symbolic links (fixes ocaml/dune#4195, @dannywillems) - Dune no longer automatically create or edit `dune-project` files (ocaml/dune#4239, fixes ocaml/dune#4108, @jeremiedimino) - Have `dune` communicate the location of the standard library directory to `merlin` (ocaml/dune#4211, fixes ocaml/dune#4188, @nojb) - Workaround incorrect exception raised by Unix.utimes (OCaml PR#8857) in Path.touch on Windows (ocaml/dune#4223, @dra27) - `dune ocaml-merlin` is now able to provide configuration for source files in the `_build` directory. (ocaml/dune#4274, @voodoos) - Automatically delete left-over Merlin files when rebuilding for the first time a project previously built with Dune `<= 2.7`. (ocaml/dune#4261, @voodoos, @aalekseyev) - Fix `ppx.exe` being compiled for the wrong target when cross-compiling (ocaml/dune#3751, fixes ocaml/dune#3698, @toots) - `dune top` correctly escapes the generated toplevel directives, and make it easier for `dune top` to locate C stubs associated to concerned libraries. (ocaml/dune#4242, fixes ocaml/dune#4231, @nojb) - Do not pass include directories containing native objects when compiling bytecode (ocaml/dune#4200, @nojb)
Commit: 26052da A pull request by opam-seasoned @rgrinberg. ☀️ All lint checks passed 26052da
☀️ Installability check (+7)
|
dune fails to compile with:
|
@nojb did you encounter this before? |
@rgrinberg this was fixed in ocaml/dune#4249 |
We'll release 2.8.4 with the additional fix. |
Should we close this in favour of 2.8.4? |
Sounds good to me |
Perfect, thanks. In the meantime the other PR was also merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embed build informations inside executable
CHANGES:
Make
patdiff
show refined diffs (Make patdiff show refined diffs dune#4257, fixes Why is patdiff instructed to show unrefined diffs? dune#4254, @hakuch)Fixed a bug that could result in needless recompilation under Windows due to
case differences in the result of
Sys.getcwd
(observed underemacs
).(Normalize case of context root under Win32 dune#3966, @nojb).
Restore compatibility with Coq < 8.10 for coq-lang < 0.3 , document
that
(using coq 0.3)
does require Coq 8.10 at least ([coq] Restore compatibility with Coq < 8.10 for coq-lang < 0.3 dune#4224, fixescoqc: ondemand: no such file or directory dune#4142, @ejgallego)
Add a META rule for 'compiler-libs.native-toplevel' (Add META rule for 'compiler-libs.native-toplevel' (ocamltoplevel.cmxa) dune#4175, @AltGr)
No longer call
chmod
on symbolic links (fixes "Rule failed to generate the following targets" with virtual package dune#4195, @dannywillems)Dune no longer automatically create or edit
dune-project
files(No longer edit or create dune-project files dune#4239, fixes Remove support for creating and editing the dune-project file automatically dune#4108, @jeremiedimino)
Have
dune
communicate the location of the standard library directory tomerlin
(merlin: communicate STDLIB directive dune#4211, fixesdune
should communicate the standard library directory tomerlin
dune#4188, @nojb)Workaround incorrect exception raised by Unix.utimes (OCaml PR#8857) in
Path.touch on Windows (Workaround OCaml PR#8857 in Path.touch dune#4223, @dra27)
dune ocaml-merlin
is now able to provide configuration for source files inthe
_build
directory. ([merlin] Also load configuration when sources are in build dir dune#4274, @voodoos)Automatically delete left-over Merlin files when rebuilding for the first time
a project previously built with Dune
<= 2.7
. ([merlin] Cleanup leftover merlin files dune#4261, @voodoos, @aalekseyev)Fix
ppx.exe
being compiled for the wrong target when cross-compiling(Add back correct host for ppx.exe dune#3751, fixes Issues cross compiling with sedlex dune#3698, @toots)
dune top
correctly escapes the generated toplevel directives, and make iteasier for
dune top
to locate C stubs associated to concerned libraries.("dune top" fixes + improvements dune#4242, fixes "dune top" output does not property escape strings dune#4231, @nojb)
Do not pass include directories containing native objects when compiling
bytecode (Do not pass native include dirs when compiling bytecode dune#4200, @nojb)