Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing opam file causes build failure #8703

Closed
Tracked by #8316
emillon opened this issue Sep 19, 2023 · 0 comments · Fixed by #8706
Closed
Tracked by #8316

missing opam file causes build failure #8703

emillon opened this issue Sep 19, 2023 · 0 comments · Fixed by #8706

Comments

@emillon
Copy link
Collaborator

emillon commented Sep 19, 2023 

          Now that I think about it, we could adjust the feature as following:

Instead of ignoring the rule completely, we could make it a normal instead of a promote rule.

Originally posted by @rgrinberg in #8662 (comment)
This was referenced Sep 18, 2023
Closed
Merged
emillon added a commit to emillon/dune that referenced this issue Sep 19, 2023
@emillon
fix: make ignored rules fallback
68546ca 
Fixes ocaml#8703

This is a lighter change than the original in ocaml#8518.

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this issue Sep 20, 2023
@emillon
fix: make ignored rules fallback
e1f578a 
Fixes ocaml#8703

This is a lighter change than the original in ocaml#8518.

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit that referenced this issue Sep 21, 2023
@emillon
fix: make ignored rules fallback (#8706)
b326c30 
Fixes #8703

This is a lighter change than the original in #8518.

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon mentioned this issue Sep 21, 2023
Closed
emillon added a commit to emillon/opam-repository that referenced this issue Sep 21, 2023
@emillon
[new release] dune (15 packages) (3.11.0~alpha3)
b8446d7 
CHANGES:

- Turn internal promote rules into fallback rules when
  `--ignore-promoted-rules` is set (ocaml/dune#8518, ocaml/dune#8706, fix ocaml/dune#8417, fix ocaml/dune#8703,
  @rgrinberg, @emillon)

- Make copy sandbox support directory targets. (ocaml/dune#8705, fixes ocaml/dune#7724, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@emillon