Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: missing opam file now causes build failure #8662

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Sep 15, 2023

Since #8518, we fail in the case where (generate_opam_files) is true but the generated file is not part of the release tarball.

@emillon emillon mentioned this pull request Sep 15, 2023
21 tasks
@emillon
Copy link
Collaborator Author

emillon commented Sep 15, 2023

@rgrinberg this is technically a regression introduced by #8518 (there are 94 failures in the alpha1 run related to that). I think we can argue that these packages have an issue, but I wonder if we can do better than just failing.

@rgrinberg
Copy link
Member

I suppose we could guard the check behind a project version. Although it makes the fix sort of useless because upstream maintainers don't want to upgrade the dune language in every single package to make the builds reproducible.

@emillon
Copy link
Collaborator Author

emillon commented Sep 15, 2023

I agree it doesn't seem ideal. Removing duplicates, it's 17 releases (12 unique packages) so it's something we can easily communicate and patch.

@emillon
Copy link
Collaborator Author

emillon commented Sep 18, 2023

I think we can set bounds + send patches upstream but this can be discussed at the next team meeting.

@rgrinberg
Copy link
Member

Upstream patches that allows for this PR to work #8512 would be welcome as well.

It's the same issue just with different rules.

@rgrinberg
Copy link
Member

Now that I think about it, we could adjust the feature as following:

Instead of ignoring the rule completely, we could make it a normal instead of a promote rule.

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon
Copy link
Collaborator Author

emillon commented Sep 19, 2023

I'll merge this as a regression test and open an issue to track this idea.

@emillon emillon merged commit 54c85b9 into ocaml:main Sep 19, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants