fix: ignoring promotion rules #8512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix__ignoring_promotion_rules
branch
from
a952a77 to
12f16e1
Compare
Bug #4401 was `(promote until-clean)` rules being incorrectly ignored by `--ignore-promoted-rules`. PR #5956 fixed it but only made the fix available to newer projects. This means that projects must update their dune versions before users can actually build this project without being affected by this bug. Since this bug fix doesn't have much the potential to break anything, we make the fix available to all versions. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 82b639c6-a417-4ae8-8cd2-fae02849ea83 -->
rgrinberg
force-pushed
the
ps/rr/fix__ignoring_promotion_rules
branch
from
12f16e1 to
0cc07e2
Compare
|
Unfortunately, some people rely on the old behavior: ocaml-community/sedlex#154 |
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #4401 was
(promote until-clean)rules being incorrectly ignored by--ignore-promoted-rules. PR #5956 fixed it but only made the fixavailable to newer projects.
This means that projects must update their dune versions before users
can actually build this project without being affected by this bug.
Since this bug fix doesn't have much the potential to break anything, we
make the fix available to all versions.
Signed-off-by: Rudi Grinberg me@rgrinberg.com