Fix #1856 #1857
Merged
Fix #1856 #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 20, 2019
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Optional implementations shouldn't force an error if their dependencies are missing Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
|
Yes it does. Thank you! |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 21, 2019
CHANGES:
- Add `${corrected-suffix}`, `${library-name}` and a few other
variables to the list of variables to upgrade. This fixes the
support for various framework producing corrections (ocaml/dune#1840, ocaml/dune#1853,
@diml)
- Fix `$ dune subst` failing because the build directory wasn't set. (ocaml/dune#1854, fix
ocaml/dune#1846, @rgrinberg)
- Configurator: Add warning to `Pkg_config.query` when a full package expression
is used. Add `Pkg_config.query_expr` for cases when the full power of
pkg-config's querying is needed (ocaml/dune#1842, fix ocaml/dune#1833, @rgrinberg)
- Fix unavailable, optional implementations eagerly breaking the build (ocaml/dune#1857,
fix ocaml/dune#1856, @rgrinberg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this fix things for you?
@Lortex