Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES:
Add
${corrected-suffix}
,${library-name}
and a few othervariables to the list of variables to upgrade. This fixes the
support for various framework producing corrections (Add corrected-suffix to the list of known variables when upgrading dune#1840, Upgrade the library-name, impl-files and intf-files variables dune#1853,
@diml)
Fix
$ dune subst
failing because the build directory wasn't set. (Fix dune subst not setting build root dune#1854, fixinternal error: cannot use build dir before its set dune#1846, @rgrinberg)
Configurator: Add warning to
Pkg_config.query
when a full package expressionis used. Add
Pkg_config.query_expr
for cases when the full power ofpkg-config's querying is needed (Fix pkg-config quoting behavior dune#1842, fix [configurator] New quoting rules may create problems. dune#1833, @rgrinberg)
Fix unavailable, optional implementations eagerly breaking the build (Fix #1856 dune#1857,
fix Error if dependencies are unavailable for an optional implementation dune#1856, @rgrinberg)