Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune (1.7.2) #13501

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Conversation

rgrinberg
Copy link
Member

CHANGES:

CHANGES:

- Add `${corrected-suffix}`, `${library-name}` and a few other
  variables to the list of variables to upgrade. This fixes the
  support for various framework producing corrections (ocaml/dune#1840, ocaml/dune#1853,
  @diml)

- Fix `$ dune subst` failing because the build directory wasn't set. (ocaml/dune#1854, fix
  ocaml/dune#1846, @rgrinberg)

- Configurator: Add warning to `Pkg_config.query` when a full package expression
  is used. Add `Pkg_config.query_expr` for cases when the full power of
  pkg-config's querying is needed (ocaml/dune#1842, fix ocaml/dune#1833, @rgrinberg)

- Fix unavailable, optional implementations eagerly breaking the build (ocaml/dune#1857,
  fix ocaml/dune#1856, @rgrinberg)
@camelus
Copy link
Contributor

camelus commented Feb 21, 2019

☀️ All lint checks passed a65d41c
  • These packages passed lint tests: dune.1.7.2

☀️ Installability check (10505 → 10506)
  • new installable packages (1): dune.1.7.2

@rgrinberg
Copy link
Member Author

All the failures are the usual offenders. I think this is good to go.

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit b607848 into ocaml:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants