Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Build's related stuff #2066

Merged
1 commit merged into from Apr 18, 2019
Merged

Refactor Build's related stuff #2066

1 commit merged into from Apr 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2019

Move all operations on Build.Repr.t directly into Build and stop exposing the internal representation. This mostly just moves code around.

@jeremiedimino
Refactor Build's related stuff
21a3dca 
Move all operations on Build.Repr.t directly into Build and stop
exposing the internal representation.

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
@ghost ghost mentioned this pull request Apr 17, 2019
Merged
emillon
emillon approved these changes Apr 18, 2019
View reviewed changes
Copy link
Collaborator

@emillon emillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Tapping into the repr was useful sometimes for debugging but if that's necessary I suppose we can add debug functions.

@ghost
Copy link
Author

ghost commented Apr 18, 2019

Seems good

@ghost ghost merged commit 0ae034b into ocaml:master Apr 18, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emillon @jeremiedimino