Global sandboxing setting #2213

aalekseyev · 2019-05-29T14:41:15Z

Add a new config option --sandbox that lets user control whether or not dune sandboxes actions by default.
The actions no longer give a boolean "sandbox" or "not sandbox", they can now additionally say "no_special_requirements". The framework allows specifying things like "this command can't work with symlinks, but it can work without sandbox or with copy-based sandbox, but we don't use that right now.
Annotated some actions in dune with no_sandboxing so that all tests keep passing with --sandbox=copy
Tested on ocaml-platform and made sure the compilation succeeds with --sandbox=copy too

aalekseyev · 2019-05-31T10:16:59Z

After talking to @diml, we agreed that we should also add to the dune language the ability to opt out or opt in to sandboxing per rule before advertising this feature to the public because it's confusing for the rules you write to never be sandboxed even if you pass --sandbox=copy.

I intend to do that soon.

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

(guided by test failures) Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

…ndencies Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

src/build_system.ml

ghost · 2019-07-23T10:56:18Z

src/module_compilation.ml

@@ -46,7 +46,10 @@ let build_cm cctx ~dep_graphs ~precompiled_cmi ~cm_kind (m : Module.t) =
        (* symlink the .cmi into the public interface directory *)
        if Module.visibility m <> Visibility.Private
        && (Obj_dir.need_dedicated_public_dir obj_dir) then
-          SC.add_rule sctx ~sandbox:false ~dir
+          SC.add_rule sctx
+            (* CR-someday aalekseyev: why do we have [no_sandboxing] here? *)


We are just doing a syscall without calling out to an external command. We can reasonably expect that sandboxing is not necessary

I added a function Action.is_useful_to_sandbox to help with that.

ghost · 2019-07-23T11:01:17Z

src/sandbox_config.ml

@@ -0,0 +1,129 @@
+open! Stdune
+
+(* ['a t] represents a total map from [Sandbox_mode.t] to ['a] *)


What about calling this Sandbox_mode.Dict.t? This is what we do in other modules such as Cm_kind, Mode, ...

Thanks, that's obviously better!

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

…e into global-sandboxing-setting

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

…e into global-sandboxing-setting

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

…e into global-sandboxing-setting

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

…e into global-sandboxing-setting

…etting

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

…etting

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft2) CHANGES: - The `action` field in the `alias` stanza is not available starting `lang dune 2.0`. The `alias` field in the `rule` stanza is a replacement. (ocaml/dune#2846, fixes 2681, @rgrinberg) - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb) - Change the default `modes` field of executables to `(mode exe)`. If one wants to build a bytecode program, it now needs to be explicitly requested via `(modes byte exe)`. (ocaml/dune#2851, @diml) - Allow `ccomp_type` as a variable for evaluating `enabled_if`. (ocaml/dune#2855, @dra27, @rgrinberg) - Stricter validation of file names in `select`. The file names of conditional sources must match the prefix and the extension of the resultant filename. (ocaml/dune#2867, @rgrinberg) - Add flag `disable_dynamically_linked_foreign_archives` to the workspace file. If the flag is set to `true` then: (i) when installing libraries, we do not install dynamic foreign archives `dll*.so`; (ii) when building executables in the `byte` mode, we statically link in foreign archives into the runtime system; (iii) we do not generate any `dll*.so` rules. (ocaml/dune#2864, @snowleopard) - Reimplement the bootstrap procedure. The new procedure is faster and should no longer stack overflow (ocaml/dune#2854, @dra27, @diml)

@bschommer

…lugin, dune-private-libs and dune-glob (2.0.0) CHANGES: - Remove existing destination files in `install` before installing the new ones. (ocaml/dune#2885, fixes ocaml/dune#2883, @bschommer) - The `action` field in the `alias` stanza is not available starting `lang dune 2.0`. The `alias` field in the `rule` stanza is a replacement. (ocaml/dune#2846, fixes 2681, @rgrinberg) - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb) - Change the default `modes` field of executables to `(mode exe)`. If one wants to build a bytecode program, it now needs to be explicitly requested via `(modes byte exe)`. (ocaml/dune#2851, @diml) - Allow `ccomp_type` as a variable for evaluating `enabled_if`. (ocaml/dune#2855, @dra27, @rgrinberg) - Stricter validation of file names in `select`. The file names of conditional sources must match the prefix and the extension of the resultant filename. (ocaml/dune#2867, @rgrinberg) - Add flag `disable_dynamically_linked_foreign_archives` to the workspace file. If the flag is set to `true` then: (i) when installing libraries, we do not install dynamic foreign archives `dll*.so`; (ii) when building executables in the `byte` mode, we statically link in foreign archives into the runtime system; (iii) we do not generate any `dll*.so` rules. (ocaml/dune#2864, @snowleopard) - Reimplement the bootstrap procedure. The new procedure is faster and should no longer stack overflow (ocaml/dune#2854, @dra27, @diml) - Allow `.opam.template` files to be generated using rules (ocaml/dune#2866, @rgrinberg)

aalekseyev requested a review from a user May 29, 2019 14:41

aalekseyev force-pushed the global-sandboxing-setting branch from 4a17fae to 30f843a Compare May 31, 2019 10:17

aalekseyev requested a review from rgrinberg May 31, 2019 10:17

aalekseyev added 6 commits July 19, 2019 15:08

add sandbox_config types

55f2aaa

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

add sandboxing_preference to config file

c8c15d5

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

propagate config to the actual logic

541e81d

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Annotate all the call sites that clearly rely on no-sandboxing.

e65d010

(guided by test failures) Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

cli

535aea5

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

discovered another breakage with ocaml platform

3b02538

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

aalekseyev force-pushed the global-sandboxing-setting branch 2 times, most recently from ba017da to a500141 Compare July 19, 2019 17:54

aalekseyev added 11 commits July 23, 2019 11:28

this bit seems unnecessary

66625d7

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

changelog entry

081e4b2

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

explore an idea: why not treat sandbox requirement as one of the depe…

61882e3

…ndencies Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

the parsing layer

0543de2

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

require dune 1.11 and update the changelog

d242a16

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

test

f83d45c

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

fix bug

52de199

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

fix test

dd0f137

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

add to the test

3b5f834

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

test preserve_file_kind

bcff36f

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

it's not clear what the solution is

67d0494

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

aalekseyev force-pushed the global-sandboxing-setting branch from f7115f7 to 67d0494 Compare July 23, 2019 10:30

ghost suggested changes Jul 23, 2019

View reviewed changes

src/build_system.ml Outdated Show resolved Hide resolved

ghost reviewed Jul 23, 2019

View reviewed changes

ghost suggested changes Jul 23, 2019

View reviewed changes

aalekseyev added 3 commits July 23, 2019 13:50

fix alias stamp file dir sandboxing

6b0cd6e

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

sandbox aliases, fix some sandboxed actions

5e6ba9c

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

introduce Sandbox_mode.Dict.t

cbf17ea

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

jeremiedimino and others added 5 commits July 25, 2019 11:24

Fix dependencies of inline tests

2007786

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

better error if targets are missing when you move them from sandbox

8375ed2

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Merge branch 'global-sandboxing-setting' of github.com:aalekseyev/dun…

af07f49

…e into global-sandboxing-setting

Fix deps of ppx.exe

0c4a65e

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

Merge branch 'global-sandboxing-setting' of github.com:aalekseyev/dun…

e022e8a

…e into global-sandboxing-setting

ghost approved these changes Jul 25, 2019

View reviewed changes

jeremiedimino and others added 6 commits July 25, 2019 13:31

doc

b280639

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

move archive_files handling to [Lib.Lib_and_module.link_flags]

32d280b

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

fix another missing dependency

56df7fa

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Merge branch 'global-sandboxing-setting' of github.com:aalekseyev/dun…

6b11a16

…e into global-sandboxing-setting

add DUNE_SANDBOX env var

ca1d6cf

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Remove unused ignore

0a9fd35

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>

ghost approved these changes Jul 25, 2019

View reviewed changes

aalekseyev added 6 commits July 25, 2019 15:34

improve exception

d8b2571

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Merge branch 'global-sandboxing-setting' of github.com:aalekseyev/dun…

149c59a

…e into global-sandboxing-setting

Merge remote-tracking branch 'origin/master' into global-sandboxing-s…

552f5b9

…etting

merge

194ef81

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

credit jdimino

12ea213

Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>

Merge remote-tracking branch 'origin/master' into global-sandboxing-s…

2740d9d

…etting

aalekseyev merged commit 5d82f38 into ocaml:master Jul 29, 2019

rgrinberg mentioned this pull request Oct 31, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft1) ocaml/opam-repository#15157

Closed

rgrinberg mentioned this pull request Oct 31, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft1) ocaml/opam-repository#15158

Closed

rgrinberg mentioned this pull request Nov 12, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft2) ocaml/opam-repository#15261

Closed

rgrinberg mentioned this pull request Nov 20, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0) ocaml/opam-repository#15334

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Global sandboxing setting #2213

Global sandboxing setting #2213

aalekseyev commented May 29, 2019

aalekseyev commented May 31, 2019 •

edited

Loading

ghost Jul 23, 2019 •

edited by ghost

Loading

aalekseyev Jul 23, 2019

ghost Jul 23, 2019

aalekseyev Jul 23, 2019

		@@ -0,0 +1,129 @@
		open! Stdune

		(* ['a t] represents a total map from [Sandbox_mode.t] to ['a] *)

Global sandboxing setting #2213

Global sandboxing setting #2213

Conversation

aalekseyev commented May 29, 2019

aalekseyev commented May 31, 2019 • edited Loading

ghost Jul 23, 2019 • edited by ghost Loading

Choose a reason for hiding this comment

aalekseyev Jul 23, 2019

Choose a reason for hiding this comment

ghost Jul 23, 2019

Choose a reason for hiding this comment

aalekseyev Jul 23, 2019

Choose a reason for hiding this comment

aalekseyev commented May 31, 2019 •

edited

Loading

ghost Jul 23, 2019 •

edited by ghost

Loading