Allow top-level libraries in `old_public_name` #2696

nojb · 2019-10-05T18:46:43Z

This PR proposes to extend (deprecated_library name ...) to allow old_public_name to be a top-level library that is not a sub-package of the main package. While it is not possible to define such libraries with dune, it is possible to do so using other build systems (e.g. menhir does this). The intent of this PR is to help migration of such projects to dune.

The syntax to redirect a top-level library foo belonging to a package p to bar is

(deprecated_library_name
 (old_public_name foo)
 (package p)
 (new_public_name bar))

Suggestions for a better syntax are welcome!

There is one subtlety though. Suppose by way of example that we have a legacy project p with a top-level library mylib (main module: MyLib) that we are porting to dune. Naturally we will now give the library the name mylib (since it has to match the name of the main module) and public name p.mylib.

(library
 (name mylib)
 (public_name p.mylib))

In order to maintain backwards compatibility we would like to do:

(deprecated_library_name
 (old_public_name mylib)
 (package p)
 (new_public_name p.mylib))

The problem is that dune will complain that there are two definitions of the library mylib (one for each stanza).

The last commit ("Fix (?) ...") tries to fix this issue, it seems to work fine, but am not 100% sure about its implications and would appreciate a second opinion.

rgrinberg · 2019-10-07T06:25:42Z

I haven't looked at the implementation yet, but it seems a bit fishy to expose this package argument.

Ideally, the deprecated stanza should belong to both packages if they exist in the dune-project.

ghost · 2019-10-07T10:44:19Z

@rgrinberg do you mean that the deprecated stanza would end up in both dune-package files? Putting the deprecated menhirLib name in the dune-package file of menhir wouldn't work since dune wouldn't eagerly go and look in <libdir>/menhir/dune-package to resolve the menhirLib name.

The problem is that dune will complain that there are two definitions of the library mylib (one for each stanza).

At the user level, there is no ambiguity. Whether we interpret menhirLib as the deprecated name for menhir.lib or the local name of menhir.lib, both point to the exact same library. We should detect such cases and simply accept them.

rgrinberg · 2019-10-08T07:46:50Z

Duplicating the stanza for both of the packages that it touches is what I had in mind. It’s not exactly in elegant as there are cases where dune cannot do it. It’s not possible when the packages aren’t in the same project for example. It still seems like a useful addition.

…

do you mean that the deprecated stanza would end up in both dune-package files? Putting the deprecated menhirLib name in the dune-package file of menhir wouldn't work since dune wouldn't eagerly go and look in <libdir>/menhir/dune-package to resolve the menhirLib name.

ghost · 2019-10-08T15:14:57Z

What is point of putting the old name in the new package?

nojb · 2019-10-08T16:14:29Z

What is point of putting the old name in the new package?

Not sure if I understand the question, but in the new package the "name" (not the public name) needs to be the same as before because it need to match the name of the main module. The "public name" could be different of course.

nojb · 2019-10-08T21:48:06Z

At the user level, there is no ambiguity. Whether we interpret menhirLib as the deprecated name for menhir.lib or the local name of menhir.lib, both point to the exact same library. We should detect such cases and simply accept them.

Good point. I pushed a commit implementing this extra check ("Handle top-level libs..."). I am not very happy with the implementation, suggestions welcome.

Also, I think a better syntax is needed.

ghost · 2019-10-09T11:26:37Z

Not sure if I understand the question, but in the new package the "name" (not the public name) needs to be the same as before because it need to match the name of the main module. The "public name" could be different of course.

Agreed. My question was not very clear, it was in response to:

Duplicating the stanza for both of the packages that it touches is what I had in mind. It’s not exactly in elegant as there are cases where dune cannot do it. It’s not possible when the packages aren’t in the same project for example. It still seems like a useful addition.

Good point. I pushed a commit implementing this extra check ("Handle top-level libs..."). I am not very happy with the implementation, suggestions welcome.

What about replacing the Lib_name.Map.of_list by Lib_name.Map.of_list_reduce and dealing with duplicated names there?

Also, I think a better syntax is needed.

Here are a few suggestions:

(old_public_name menhirLib in package menhir)
(old_public_name menhirLib (package menhir))

BTW, I was thinking again about what we were talking about the other day on slack, and my gut feeling is that things will work better in the future if all toplevel names appear in the dune-project file. For instance, we could add a field in the package stanza to declare all the toplevel names:

(package
 (name menhir)
 (claim_deprecated_package_names menhirLib))

to indicate that menhir claims the menhirLib package name. Then we would only be allowed to use an old_public_name that is part of a package names mentioned in the dune-project file. We might not even need the (package ...) field anymore in the deprecated_library_name stanza.

nojb · 2019-10-09T15:50:13Z

BTW, I was thinking again about what we were talking about the other day on slack, and my gut feeling is that things will work better in the future if all toplevel names appear in the dune-project file. For instance, we could add a field in the package stanza to declare all the toplevel names:
(package
 (name menhir)
 (claim_deprecated_package_names menhirLib))
to indicate that menhir claims the menhirLib package name. Then we would only be allowed to use an old_public_name that is part of a package names mentioned in the dune-project file. We might not even need the (package ...) field anymore in the deprecated_library_name stanza.

Indeed, it sounds like a better place to put this information; I will give it a try. Thanks!

nojb · 2019-10-11T13:00:45Z

I reworked this PR.

Now there is a new field (deprecated_package_names pkg1 pkg2 ...) in the (package (name p) ...) stanza in dune-project. The names pkg1, pkg2, ... can be used in the (old_public_name ...) field of the (deprecated_library_name ...) stanza. These names are interpreted as top-level libraries attached to p. Appropriate META files are generated.

I refactored a bit the code checking for duplicate library definitions to handle the fact that the same name can appear in the (deprecated_package_names ...) field and in the (name ...) field of a library.

Review welcome. Thanks!

src/dune/dune_file.ml

src/dune/package.mli

ghost · 2019-10-14T07:44:24Z

Looks good. We also need to generate a dune-package file for deprecated package names, otherwise deprecated library names won't translate to Redirect when used from another project, and so this would break (implicit_transitive_deps false).

BTW, this PR doesn't allow (old_public_name <deprecated-name>.<something>). Would that be useful to support?

ghost · 2019-10-14T07:45:00Z

src/dune/install_rules.ml

@@ -170,17 +174,37 @@ end = struct
               let dune_package_file =
                 Package_paths.dune_package_file ctx pkg
               in
+               let toplevel_lib_meta_files =


It seems to me that we could use pkg.deprecatd_package_names here

We could, but right now we don't check that every name mentioned in (deprecated_package_names) actually appears in a deprecated_library_name stanza. Should we enforce that?

This is similar to checking that packages are empty, which we don't do, so we shouldn't do it here either.

nojb · 2019-10-14T09:49:09Z

Looks good. We also need to generate a dune-package file for deprecated package names, otherwise deprecated library names won't translate to Redirect when used from another project, and so this would break (implicit_transitive_deps false).

I am not very familiar with dune-package files; should this file be generated in the same directory as the META file?

ghost · 2019-10-14T10:05:17Z

Yep. Basically, dune-package are dune's version of META files. They are in s-expression syntax and store more information. They are not meant to be read by tools other than dune.

nojb · 2019-10-14T11:12:23Z

Yep. Basically, dune-package are dune's version of META files. They are in s-expression syntax and store more information. They are not meant to be read by tools other than dune.

OK; is it correct that the redirection entry for the deprecated package should not appear then in the dune-package file of the main package ?

ghost · 2019-10-14T11:21:36Z

Yes, that's correct. For instance, for menhir, the (deprecated_library_name (old_public_name menhirLib) (new_public_name menhir.lib)) stanza should appear only in <libdir>/menhirLib/dune-package. Same for the META file.

nojb · 2019-10-14T12:18:04Z

Yes, that's correct. For instance, for menhir, the (deprecated_library_name (old_public_name menhirLib) (new_public_name menhir.lib)) stanza should appear only in <libdir>/menhirLib/dune-package. Same for the META file.

Got it, thanks. One more question : the name in the dune-package file for the deprecated library should be the name of the deprecated library (eg menhirLib) or of the main package (eg menhir) ?

ghost · 2019-10-14T12:32:18Z

it should be menhirLib. In fact, it's basically redundant with the directory name.

nojb · 2019-10-14T12:44:57Z

it should be menhirLib. In fact, it's basically redundant with the directory name.

OK. I added the generation of dune-package files, and I think all other issues have been addressed.

src/dune/install_rules.ml

ghost · 2019-10-15T07:43:39Z

Regarding allowing <deprecated-name>.<sometihng>, the more I think about it and the more I think we should allow it. It doesn't seem very complicated to support, and if someone needs it in the future we won't need more versioning. What do you think?

nojb · 2019-10-16T09:32:45Z

Well, if you write (package (name foo) (deprecated_package_names bar)), then the files of bar such as bar/META will be installed as part of package foo, right? Otherwise, we'd need a separate opam entry for bar

Yes you are right, I forgot we need to associate deprecated packages with the package they need to be installed by. Another possibility is to use:

(package (name foo) (deprecated_by bar))

for a deprecated name foo. But I am also OK leaving things as they are.

ghost · 2019-10-16T10:49:47Z

That seems like a valid choice, but I feel like the choice of syntax should reflect the behaviour. More precisely:

if the deprecated names are are a field of the main package, then the files from deprecated packages are just part of the main package and there is no separate opam package
if the deprecated package has its own top-level stanza, then the deprecated package should have its own <package>.opam file, generate its own <package>.install file and ultimately have its own entry in opam

Given that the use case for this feature is for project for which the ocamlfind package name doesn't match the opam package name, I feel like option 1 is better.

nojb · 2019-10-16T11:10:53Z

Given that the use case for this feature is for project for which the ocamlfind package name doesn't match the opam package name, I feel like option 1 is better.

Makes sense. I added a couple of more tests and rebased to clean up the history. Unless someone objects I am planning to merge today after CI pases.

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft1) CHANGES: - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb)

@rgrinberg

…lugin, dune-private-libs and dune-glob (2.0.0+draft2) CHANGES: - The `action` field in the `alias` stanza is not available starting `lang dune 2.0`. The `alias` field in the `rule` stanza is a replacement. (ocaml/dune#2846, fixes 2681, @rgrinberg) - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Change `implicit_transive_deps` to be false. Implicit transitive deps now must be manually enabled (ocaml/dune#2306, @rgrinberg) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb) - Change the default `modes` field of executables to `(mode exe)`. If one wants to build a bytecode program, it now needs to be explicitly requested via `(modes byte exe)`. (ocaml/dune#2851, @diml) - Allow `ccomp_type` as a variable for evaluating `enabled_if`. (ocaml/dune#2855, @dra27, @rgrinberg) - Stricter validation of file names in `select`. The file names of conditional sources must match the prefix and the extension of the resultant filename. (ocaml/dune#2867, @rgrinberg) - Add flag `disable_dynamically_linked_foreign_archives` to the workspace file. If the flag is set to `true` then: (i) when installing libraries, we do not install dynamic foreign archives `dll*.so`; (ii) when building executables in the `byte` mode, we statically link in foreign archives into the runtime system; (iii) we do not generate any `dll*.so` rules. (ocaml/dune#2864, @snowleopard) - Reimplement the bootstrap procedure. The new procedure is faster and should no longer stack overflow (ocaml/dune#2854, @dra27, @diml)

@bschommer

…lugin, dune-private-libs and dune-glob (2.0.0) CHANGES: - Remove existing destination files in `install` before installing the new ones. (ocaml/dune#2885, fixes ocaml/dune#2883, @bschommer) - The `action` field in the `alias` stanza is not available starting `lang dune 2.0`. The `alias` field in the `rule` stanza is a replacement. (ocaml/dune#2846, fixes 2681, @rgrinberg) - Introduce `alias` and `package` fields to the `rule` stanza. This is the preferred way of attaching rules to aliases. (ocaml/dune#2744, @rgrinberg) - Add field `(optional)` for executable stanzas (ocaml/dune#2463, fixes ocaml/dune#2433, @bobot) - Infer targets for rule stanzas expressed in long form (ocaml/dune#2494, fixes ocaml/dune#2469, @NathanReb) - Indicate the progress of the initial file tree loading (ocaml/dune#2459, fixes ocaml/dune#2374, @bobot) - Build `.cm[ox]` files for executables more eagerly. This speeds up builds at the cost of building unnecessary artifacts in some cases. Some of these extra artifacts can fail to built, so this is a breaking change. (ocaml/dune#2268, @rgrinberg) - Do not put the `<package>.install` files in the source tree unless `-p` or `--promote-install-files` is passed on the command line (ocaml/dune#2329, @diml) - Compilation units of user defined executables are now mangled by default. This is done to prevent the accidental collision with library dependencies of the executable. (ocaml/dune#2364, fixes ocaml/dune#2292, @rgrinberg) - Enable `(explicit_js_mode)` by default. (ocaml/dune#1941, @nojb) - Add an option to clear the console in-between builds with `--terminal-persistence=clear-on-rebuild` - Stop symlinking object files to main directory for stanzas defined `jbuild` files (ocaml/dune#2440, @rgrinberg) - Library names are now validated in a strict fashion. Previously, invalid names would be allowed for unwrapped libraries (ocaml/dune#2442, @rgrinberg) - mli only modules must now be explicitly declared. This was previously a warning and is now an error. (ocaml/dune#2442, @rgrinberg) - Modules filtered out from the module list via the Ordered Set Language must now be actual modules. (ocaml/dune#2442, @rgrinberg) - Actions which introduce targets where new targets are forbidden (e.g. preprocessing) are now an error instead of a warning. (ocaml/dune#2442, @rgrinberg) - No longer install a `jbuilder` binary. (ocaml/dune#2441, @diml) - Stub names are no longer allowed relative paths. This was previously a warning and is now an error (ocaml/dune#2443, @rgrinberg). - Define (paths ...) fields in (context ...) definitions in order to set or extend any PATH-like variable in the context environment. (ocaml/dune#2426, @nojb) - The `diff` action will always normalize newlines before diffing. Perviousy, it would not do this normalization for rules defined in jbuild files. (ocaml/dune#2457, @rgrinberg) - Modules may no longer belong to more than one stanza. This was previously allowed only in stanzas defined in `jbuild` files. (ocaml/dune#2458, @rgrinberg) - Remove support for `jbuild-ignore` files. They have been replaced by the the `dirs` stanza in `dune` files. (ocaml/dune#2456, @rgrinberg) - Add a new config option `sandboxing_preference`, the cli argument `--sandbox`, and the dep spec `sandbox` in dune language. These let the user control the level of sandboxing done by dune per rule and globally. The rule specification takes precedence. The global configuration merely specifies the default. (ocaml/dune#2213, @aalekseyev, @diml) - Remove support for old style subsystems. Dune will now emit a warning to reinstall the library with the old style subsystem. (ocaml/dune#2480, @rgrinberg) - Add action (with-stdin-from <file> <action>) to redirect input from <file> when performing <action>. (ocaml/dune#2487, @nojb) - Change the automatically generated odoc index to only list public modules. This only affects unwrapped libraries (ocaml/dune#2479, @rgrinberg) - Set up formatting rules by default. They can be configured through a new `(formatting)` stanza in `dune-project` (ocaml/dune#2347, fixes ocaml/dune#2315, @emillon) - Change default target from `@install` to `@all`. (ocaml/dune#2449, fixes ocaml/dune#1220, @rgrinberg) - Include building stubs in `@check` rules. (@rgrinberg, ocaml/dune#2530) - Get rid of ad-hoc rules for guessing the version. Dune now only relies on the version written in the `dune-project` file and no longer read `VERSION` or similar files (ocaml/dune#2541, @diml) - In `(diff? x y)` action, require `x` to exist and register a dependency on that file. (ocaml/dune#2486, @aalekseyev) - On Windows, an .exe suffix is no longer added implicitly to binary names that already end in .exe. Second, when resolving binary names, .opt variants are no longer chosen automatically. (ocaml/dune#2543, @nojb) - Make `(diff? x y)` move the correction file (`y`) away from the build directory to promotion staging area. This makes corrections work with sandboxing and in general reduces build directory pollution. (ocaml/dune#2486, @aalekseyev, fixes ocaml/dune#2482) - `c_flags`, `c_names` and `cxx_names` are now supported in `executable` and `executables` stanzas. (ocaml/dune#2562, @nojb) Note: this feature has been subsequently extended into a separate `foreign_stubs` field. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Remove git integration from `$ dune upgrade` (ocaml/dune#2565, @rgrinberg) - Add a `--disable-promotion` to disable all modification to the source directory. There's also a corresponding `DUNE_DISABLE_PROMOTION` environment variable. (ocaml/dune#2588, fix ocaml/dune#2568, @rgrinberg) - Add a `forbidden_libraries` field to prevent some library from being linked in an executable. This help detecting who accidently pulls in `unix` for instance (ocaml/dune#2570, @diml) - Fix incorrect error message when a variable is expanded in static context: `%{lib:lib:..}` when the library does not exist. (ocaml/dune#2597, fix ocaml/dune#1541, @rgrinberg) - Add `--sections` option to `$ dune install` to install subsections of .install files. This is useful for installing only the binaries in a workspace for example. (ocaml/dune#2609, fixes ocaml/dune#2554, @rgrinberg) - Drop support for `jbuild` and `jbuild-ignore` files (ocaml/dune#2607, @diml) - Add a `dune-action-plugin` library for describing dependencies direcly in the executable source. Programs that use this feature can be run by a new action (dynamic-run <progn> ...). (ocaml/dune#2635, @staronj, @aalekseyev) - Stop installing the `ocaml-syntax-shims` binary. In order to use `future_syntax`, one now need to depend on the `ocaml-syntax-shims` package (ocaml/dune#2654, @diml) - Add support for dependencies that are re-exported. Such dependencies are marked with`re_export` and will automatically be provided to users of a library (ocaml/dune#2605, @rgrinberg) - Add a `deprecated_library_name` stanza to redirect old names after a library has been renamed (ocaml/dune#2528, @diml) - Error out when a `preprocessor_deps` field is present but not `preprocess` field is. It is a warning with Dune 1.x projects (ocaml/dune#2660, @Julow) - Dune will use `-output-complete-exe` instead of `-custom` when compiling self-contained bytecode executables whenever this options is available (OCaml version >= 4.10) (ocaml/dune#2692, @nojb) - Add action `(with-accepted-exit-codes <pred> <action>)` to specify the set of successful exit codes of `<action>`. `<pred>` is specified using the predicate language. (ocaml/dune#2699, @nojb) - Do not setup rules for disabled libraries (ocaml/dune#2491, fixes ocaml/dune#2272, @bobot) - Configurator: filter out empty flags from `pkg-config` (ocaml/dune#2716, @AltGr) - `no_keep_locs` is a no-op for projects that use `lang dune` older than 2.0. In projects where the language is at least `2.0`, the field is now forbidden. (ocaml/dune#2752, fixes ocaml/dune#2747, @rgrinberg) - Extend support for foreign sources and archives via the `(foreign_library ...)` stanza as well as the `(foreign_stubs ...)` and `(foreign_archives ...)` fields. (ocaml/dune#2659, RFC ocaml/dune#2650, @snowleopard) - Add (deprecated_package_names) field to (package) declaration in dune-project. The names declared here can be used in the (old_public_name) field of (deprecated_library_name) stanza. These names are interpreted as library names (not prefixed by a package name) and appropiate redirections are setup in their META files. This feaure is meant to migrate old libraries which do not follow Dune's convention of prefixing libraries with the package name. (ocaml/dune#2696, @nojb) - The fields `license`, `authors`, `maintainers`, `source`, `bug_reports`, `homepage`, and `documentation` of `dune-project` can now be overriden on a per-package basis. (ocaml/dune#2774, @nojb) - Change the default `modes` field of executables to `(mode exe)`. If one wants to build a bytecode program, it now needs to be explicitly requested via `(modes byte exe)`. (ocaml/dune#2851, @diml) - Allow `ccomp_type` as a variable for evaluating `enabled_if`. (ocaml/dune#2855, @dra27, @rgrinberg) - Stricter validation of file names in `select`. The file names of conditional sources must match the prefix and the extension of the resultant filename. (ocaml/dune#2867, @rgrinberg) - Add flag `disable_dynamically_linked_foreign_archives` to the workspace file. If the flag is set to `true` then: (i) when installing libraries, we do not install dynamic foreign archives `dll*.so`; (ii) when building executables in the `byte` mode, we statically link in foreign archives into the runtime system; (iii) we do not generate any `dll*.so` rules. (ocaml/dune#2864, @snowleopard) - Reimplement the bootstrap procedure. The new procedure is faster and should no longer stack overflow (ocaml/dune#2854, @dra27, @diml) - Allow `.opam.template` files to be generated using rules (ocaml/dune#2866, @rgrinberg)

nojb force-pushed the top_level_old_name branch from f55e87e to 9ce8d0f Compare October 8, 2019 21:43

nojb changed the title ~~Allow top-level libraries in old_public_name~~ [WIP] Allow top-level libraries in old_public_name Oct 9, 2019

nojb force-pushed the top_level_old_name branch 4 times, most recently from 67b5aca to b70579f Compare October 11, 2019 12:46

nojb changed the title ~~[WIP] Allow top-level libraries in old_public_name~~ Allow top-level libraries in old_public_name Oct 11, 2019

nojb requested review from emillon and rgrinberg as code owners October 11, 2019 12:56

ghost suggested changes Oct 14, 2019

View reviewed changes

src/dune/dune_file.ml Outdated Show resolved Hide resolved

src/dune/dune_file.ml Outdated Show resolved Hide resolved

src/dune/package.mli Outdated Show resolved Hide resolved

ghost suggested changes Oct 14, 2019

View reviewed changes

ghost suggested changes Oct 15, 2019

View reviewed changes

src/dune/install_rules.ml Outdated Show resolved Hide resolved

nojb force-pushed the top_level_old_name branch 2 times, most recently from cb1f1c3 to c958181 Compare October 16, 2019 11:10

nojb force-pushed the top_level_old_name branch from c958181 to 8e45eb8 Compare October 16, 2019 12:40

nojb added 7 commits October 16, 2019 14:49

Add Lib.Resolve_result.to_dyn

306b4c8

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

Add Dune_package.{to_dyn,Or_meta.pp}

a19fac2

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

Add (deprecated_package_names ...) field

92abcaf

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

Add test

90d2cd0

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

Update CHANGES.md

c2b0965

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

Update manual

d978e31

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

make fmt

8482631

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>

nojb force-pushed the top_level_old_name branch from 8e45eb8 to 8482631 Compare October 16, 2019 13:00

nojb closed this Oct 16, 2019

nojb reopened this Oct 16, 2019

nojb closed this Oct 16, 2019

nojb reopened this Oct 16, 2019

nojb merged commit 3843510 into ocaml:master Oct 16, 2019

nojb deleted the top_level_old_name branch October 16, 2019 13:38

rgrinberg mentioned this pull request Oct 31, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft1) ocaml/opam-repository#15157

Closed

rgrinberg mentioned this pull request Oct 31, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft1) ocaml/opam-repository#15158

Closed

rgrinberg mentioned this pull request Nov 12, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0+draft2) ocaml/opam-repository#15261

Closed

rgrinberg mentioned this pull request Nov 20, 2019

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.0.0) ocaml/opam-repository#15334

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow top-level libraries in `old_public_name` #2696

Allow top-level libraries in `old_public_name` #2696

nojb commented Oct 5, 2019 •

edited

Loading

rgrinberg commented Oct 7, 2019

ghost commented Oct 7, 2019

rgrinberg commented Oct 8, 2019 via email

ghost commented Oct 8, 2019

nojb commented Oct 8, 2019

nojb commented Oct 8, 2019

ghost commented Oct 9, 2019

nojb commented Oct 9, 2019

nojb commented Oct 11, 2019

ghost commented Oct 14, 2019

ghost Oct 14, 2019

nojb Oct 14, 2019

ghost Oct 14, 2019

nojb commented Oct 14, 2019

ghost commented Oct 14, 2019

nojb commented Oct 14, 2019

ghost commented Oct 14, 2019

nojb commented Oct 14, 2019

ghost commented Oct 14, 2019

nojb commented Oct 14, 2019

ghost commented Oct 15, 2019

nojb commented Oct 16, 2019

ghost commented Oct 16, 2019

nojb commented Oct 16, 2019

Allow top-level libraries in old_public_name #2696

Allow top-level libraries in old_public_name #2696

Conversation

nojb commented Oct 5, 2019 • edited Loading

rgrinberg commented Oct 7, 2019

ghost commented Oct 7, 2019

rgrinberg commented Oct 8, 2019 via email

ghost commented Oct 8, 2019

nojb commented Oct 8, 2019

nojb commented Oct 8, 2019

ghost commented Oct 9, 2019

nojb commented Oct 9, 2019

nojb commented Oct 11, 2019

ghost commented Oct 14, 2019

ghost Oct 14, 2019

Choose a reason for hiding this comment

nojb Oct 14, 2019

Choose a reason for hiding this comment

ghost Oct 14, 2019

Choose a reason for hiding this comment

nojb commented Oct 14, 2019

ghost commented Oct 14, 2019

nojb commented Oct 14, 2019

ghost commented Oct 14, 2019

nojb commented Oct 14, 2019

ghost commented Oct 14, 2019

nojb commented Oct 14, 2019

ghost commented Oct 15, 2019

nojb commented Oct 16, 2019

ghost commented Oct 16, 2019

nojb commented Oct 16, 2019

Allow top-level libraries in `old_public_name` #2696

Allow top-level libraries in `old_public_name` #2696

nojb commented Oct 5, 2019 •

edited

Loading