[2.9] [coq] Fix computation of profile flags #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
2.9+coq+fix_env_flags
branch
from
46fa962
to
6e247c7
Compare
* Add test case for coq + env Signed-off-by: Rudi Grinberg <me@rgrinberg.com> * [coq] Fix computation of profile flags. This is very subtle and I am not sure I do understand all the subtleties here, but moving the expansion to the inheritance function seems like the right thing to do. Added almost exhaustive test cases. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org> Co-authored-by: Rudi Grinberg <me@rgrinberg.com>
This wasn't done in the past as to avoid the ugly grep, but the flag logic is delicate so we must start testing it properly. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
force-pushed
the
2.9+coq+fix_env_flags
branch
from
6e247c7
to
4196f00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4749 #4748