Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] [coq] Fix computation of profile flags #4758

Merged
merged 2 commits into from
Jun 19, 2021
Merged

[2.9] [coq] Fix computation of profile flags #4758

merged 2 commits into from
Jun 19, 2021

Commits on Jun 19, 2021

  1. [coq] Fix computation of profile flags. (ocaml#4749) 

    * Add test case for coq + env

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

* [coq] Fix computation of profile flags.

This is very subtle and I am not sure I do understand all the
subtleties here, but moving the expansion to the inheritance function
seems like the right thing to do.

Added almost exhaustive test cases.

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>

Co-authored-by: Rudi Grinberg <me@rgrinberg.com>
    @ejgallego @rgrinberg
    ejgallego and rgrinberg committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    b231bbf View commit details
    Browse the repository at this point in the history

  2. [coq] Add test cases for flags 

    This wasn't done in the past as to avoid the ugly grep, but the flag
logic is delicate so we must start testing it properly.

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
    @ejgallego
    ejgallego committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    4196f00 View commit details
    Browse the repository at this point in the history