Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): Check that git repo dir is accessible #9019

Merged
merged 4 commits into from
Oct 29, 2023
Merged

fix(pkg): Check that git repo dir is accessible #9019

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d105c4b
fix(pkg): Check that git repo dir is accessible
Leonidas-from-XIV Oct 27, 2023
646a2c4
_
rgrinberg Oct 29, 2023
e8954e5
_
rgrinberg Oct 29, 2023
5372e51
_
rgrinberg Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/dune_pkg/rev_store.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,19 @@ let show { dir } (Rev rev) path =

let load_or_create ~dir =
let t = { dir } in
(* TODO might as well double check it's a directory *)
match Path.exists dir with
| true -> Fiber.return t
| false ->
Path.mkdir_p dir;
let+ () = run t [ "init"; "--bare" ] in
t
let* () = Fiber.return () in
let+ () =
match Fpath.mkdir_p (Path.to_string dir) with
| Already_exists -> Fiber.return ()
rgrinberg marked this conversation as resolved.
Show resolved Hide resolved
| Created -> run t [ "init"; "--bare" ]
| exception Unix.Unix_error (e, x, y) ->
User_error.raise
[ Pp.textf "%s isn't a directory" (Path.to_string_maybe_quoted dir)
; Pp.textf "reason: %s" (Unix_error.Detailed.to_string_hum (e, x, y))
]
~hints:[ Pp.text "delete this file or check its permissions" ]
in
t
;;

module Remote = struct
Expand Down
Loading