Add a new option to mute the hover response. #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4650Details
💛 - Coveralls |
xvw
approved these changes
Dec 10, 2024
The code action need explicit enabling
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jan 9, 2025
CHANGES: ## Features - Add a new server option `standardHover`, that can be used by clients to disable the default hover provider. When `standardHover = false` `textDocument/hover` requests always returns with empty result. (ocaml/ocaml-lsp#1416)
voodoos
added a commit
to voodoos/ocaml-lsp
that referenced
this pull request
Jun 6, 2025
* Add option to mute the hover + ensure jump CA is disabled
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 23, 2025
CHANGES: ## Features - Make `inlay-hint` for function parameters configurable (ocaml/ocaml-lsp#1515) - Add custom `ocamllsp/jumpToTypedHole` to navigate through typed holes (ocaml/ocaml-lsp#1516) - Add a code-action for combining pattern cases (just relaying on regex) (ocaml/ocaml-lsp#1514) - Allow (by configuration) shortening of diagnostics (just highlighting the first line) (ocaml/ocaml-lsp#1513) - Fix `yojson_of_t` for `Nullable_option`: serialize `None` as `Null` instead of asserting false (ocaml/ocaml-lsp#1525 fixes ocaml/ocaml-lsp#1524) ## Fixes - Support for `class`, `class type`, `method` and `property` for `DocumentSymbol` query (ocaml/ocaml-lsp#1487 fixes ocaml/ocaml-lsp#1449) - Fix `inlay-hint` for function parameters (ocaml/ocaml-lsp#1515) - More precise diagnostics in the event of a failed identifier search (`Definition_query`) (ocaml/ocaml-lsp#1518) - Remove `ocamlformat` application after `destruct` (that remove some useful parenthesis) (ocaml/ocaml-lsp#1519) - Add a new server option `standardHover`, that can be used by clients to disable the default hover provider. When `standardHover = false` `textDocument/hover` requests always returns with empty result. (ocaml/ocaml-lsp#1416)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 23, 2025
CHANGES: ## Features - Make `inlay-hint` for function parameters configurable (ocaml/ocaml-lsp#1515) - Add custom `ocamllsp/jumpToTypedHole` to navigate through typed holes (ocaml/ocaml-lsp#1516) - Add a code-action for combining pattern cases (just relaying on regex) (ocaml/ocaml-lsp#1514) - Allow (by configuration) shortening of diagnostics (just highlighting the first line) (ocaml/ocaml-lsp#1513) - Fix `yojson_of_t` for `Nullable_option`: serialize `None` as `Null` instead of asserting false (ocaml/ocaml-lsp#1525 fixes ocaml/ocaml-lsp#1524) ## Fixes - Support for `class`, `class type`, `method` and `property` for `DocumentSymbol` query (ocaml/ocaml-lsp#1487 fixes ocaml/ocaml-lsp#1449) - Fix `inlay-hint` for function parameters (ocaml/ocaml-lsp#1515) - More precise diagnostics in the event of a failed identifier search (`Definition_query`) (ocaml/ocaml-lsp#1518) - Remove `ocamlformat` application after `destruct` (that remove some useful parenthesis) (ocaml/ocaml-lsp#1519) - Add a new server option `standardHover`, that can be used by clients to disable the default hover provider. When `standardHover = false` `textDocument/hover` requests always returns with empty result. (ocaml/ocaml-lsp#1416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know it is not possible to disable the default hover provider on the client side in vscode due to how the official LSP client implementation manage it.
However it is sometimes necessary to disable that hover provider to provide alternative information in the hover tooltips without additional clutter.
This PR introduces an option that allows the client to ask the server to not return anything when hover requests are made.
The diff is a bit larger than necessary because
dune build @linthad not been run when options when last updated so the inlining has changed a bit.The first use case for this option is described in this vscode-ocaml-platform PR: ocamllabs/vscode-ocaml-platform#1675