Correct nullable_option serialization #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
approved these changes
May 4, 2025
There was a problem hiding this comment.
Thanks for having taken the time to open the PR @crackcomm !
This change looks very reasonable to me, could you add a changelog entry ?
Changed `Nullable_option.yojson_of_t` to serialize `None` as `Null` instead of asserting false.
|
Done. |
voodoos
pushed a commit
to voodoos/ocaml-lsp
that referenced
this pull request
Jun 6, 2025
Changed `Nullable_option.yojson_of_t` to serialize `None` as `Null` instead of asserting false.
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 23, 2025
CHANGES: ## Features - Make `inlay-hint` for function parameters configurable (ocaml/ocaml-lsp#1515) - Add custom `ocamllsp/jumpToTypedHole` to navigate through typed holes (ocaml/ocaml-lsp#1516) - Add a code-action for combining pattern cases (just relaying on regex) (ocaml/ocaml-lsp#1514) - Allow (by configuration) shortening of diagnostics (just highlighting the first line) (ocaml/ocaml-lsp#1513) - Fix `yojson_of_t` for `Nullable_option`: serialize `None` as `Null` instead of asserting false (ocaml/ocaml-lsp#1525 fixes ocaml/ocaml-lsp#1524) ## Fixes - Support for `class`, `class type`, `method` and `property` for `DocumentSymbol` query (ocaml/ocaml-lsp#1487 fixes ocaml/ocaml-lsp#1449) - Fix `inlay-hint` for function parameters (ocaml/ocaml-lsp#1515) - More precise diagnostics in the event of a failed identifier search (`Definition_query`) (ocaml/ocaml-lsp#1518) - Remove `ocamlformat` application after `destruct` (that remove some useful parenthesis) (ocaml/ocaml-lsp#1519) - Add a new server option `standardHover`, that can be used by clients to disable the default hover provider. When `standardHover = false` `textDocument/hover` requests always returns with empty result. (ocaml/ocaml-lsp#1416)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 23, 2025
CHANGES: ## Features - Make `inlay-hint` for function parameters configurable (ocaml/ocaml-lsp#1515) - Add custom `ocamllsp/jumpToTypedHole` to navigate through typed holes (ocaml/ocaml-lsp#1516) - Add a code-action for combining pattern cases (just relaying on regex) (ocaml/ocaml-lsp#1514) - Allow (by configuration) shortening of diagnostics (just highlighting the first line) (ocaml/ocaml-lsp#1513) - Fix `yojson_of_t` for `Nullable_option`: serialize `None` as `Null` instead of asserting false (ocaml/ocaml-lsp#1525 fixes ocaml/ocaml-lsp#1524) ## Fixes - Support for `class`, `class type`, `method` and `property` for `DocumentSymbol` query (ocaml/ocaml-lsp#1487 fixes ocaml/ocaml-lsp#1449) - Fix `inlay-hint` for function parameters (ocaml/ocaml-lsp#1515) - More precise diagnostics in the event of a failed identifier search (`Definition_query`) (ocaml/ocaml-lsp#1518) - Remove `ocamlformat` application after `destruct` (that remove some useful parenthesis) (ocaml/ocaml-lsp#1519) - Add a new server option `standardHover`, that can be used by clients to disable the default hover provider. When `standardHover = false` `textDocument/hover` requests always returns with empty result. (ocaml/ocaml-lsp#1416)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 24, 2025
CHANGES: ## Features - Make `inlay-hint` for function parameters configurable (ocaml/ocaml-lsp#1515) - Add custom `ocamllsp/jumpToTypedHole` to navigate through typed holes (ocaml/ocaml-lsp#1516) - Add a code-action for combining pattern cases (just relaying on regex) (ocaml/ocaml-lsp#1514) - Allow (by configuration) shortening of diagnostics (just highlighting the first line) (ocaml/ocaml-lsp#1513) - Fix `yojson_of_t` for `Nullable_option`: serialize `None` as `Null` instead of asserting false (ocaml/ocaml-lsp#1525 fixes ocaml/ocaml-lsp#1524) ## Fixes - Support for `class`, `class type`, `method` and `property` for `DocumentSymbol` query (ocaml/ocaml-lsp#1487 fixes ocaml/ocaml-lsp#1449) - Fix `inlay-hint` for function parameters (ocaml/ocaml-lsp#1515) - More precise diagnostics in the event of a failed identifier search (`Definition_query`) (ocaml/ocaml-lsp#1518) - Remove `ocamlformat` application after `destruct` (that remove some useful parenthesis) (ocaml/ocaml-lsp#1519)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 24, 2025
CHANGES: ## Features - Make `inlay-hint` for function parameters configurable (ocaml/ocaml-lsp#1515) - Add custom `ocamllsp/jumpToTypedHole` to navigate through typed holes (ocaml/ocaml-lsp#1516) - Add a code-action for combining pattern cases (just relaying on regex) (ocaml/ocaml-lsp#1514) - Allow (by configuration) shortening of diagnostics (just highlighting the first line) (ocaml/ocaml-lsp#1513) - Fix `yojson_of_t` for `Nullable_option`: serialize `None` as `Null` instead of asserting false (ocaml/ocaml-lsp#1525 fixes ocaml/ocaml-lsp#1524) ## Fixes - Support for `class`, `class type`, `method` and `property` for `DocumentSymbol` query (ocaml/ocaml-lsp#1487 fixes ocaml/ocaml-lsp#1449) - Fix `inlay-hint` for function parameters (ocaml/ocaml-lsp#1515) - More precise diagnostics in the event of a failed identifier search (`Definition_query`) (ocaml/ocaml-lsp#1518) - Remove `ocamlformat` application after `destruct` (that remove some useful parenthesis) (ocaml/ocaml-lsp#1519)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Nullable_option.yojson_of_tto serializeNoneasNullinstead of asserting false.Fixes #1524