Skip to content

Correct nullable_option serialization #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

Correct nullable_option serialization #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Add custom `ocamllsp/jumpToTypedHole` to navigate through typed holes (#1516)
- Add a code-action for combining pattern cases (just relaying on regex) (#1514)
- Allow (by configuration) shortening of diagnostics (just highlighting the first line) (#1513)
- Fix `yojson_of_t` for `Nullable_option`: serialize `None` as `Null` instead of asserting false (#1525 fixes #1524)

## Fixes

Expand Down
2 changes: 1 addition & 1 deletion lsp/src/import.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ module Json = struct
;;

let yojson_of_t f = function
| None -> assert false
| None -> `Null
| Some s -> f s
;;
end
Expand Down