Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lwt 4.1.0: concurrency library, now under MIT license #12250

Merged
merged 2 commits into from
Jun 28, 2018

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Jun 26, 2018

The main purpose of this release is that it is the first one under the MIT license.

From the changelog:

Additions

Bugs fixed

Miscellaneous

@camelus
Copy link
Contributor

camelus commented Jun 26, 2018

❗ opam-lint warnings da0952a
  • lwt.4.1.0 has some warnings:

    • warning 41: Some packages are mentionned in package scripts of features, but there is no dependency or depopt toward them:
      "camlp4", "lwt_camlp4", "lwt_log", "lwt_ppx"
  • These packages passed lint tests: lwt_ppx.1.2.1


✅ Installability check (9031 → 9033)
  • new installable packages (2): lwt.4.1.0 lwt_ppx.1.2.1

@aantron
Copy link
Contributor Author

aantron commented Jun 27, 2018

I constrained the following packages with ocaml-version < "4.06.0", because they are not -safe-string-compatible:

amqp-client 1.0.1 and 1.0.2, bencode-rpc 1.0, bencode 0.2, dht 0.1.3 lwt-binio 0.2.1 (cc @hcarty), xenctrl (cc @andyhhp), ocplib-concur (cc @lefessan), xen-evtchn 1.0.1, 1.0.3, 1.0.4, 1.0.5, zbar (cc @vbmithr)


statsd-client assumes that Unix.socket and Lwt_unix.socket have compatible type signatures, but Unix.socket gained a ?cloexec argument in 4.05.0, while Lwt_unix.socket doesn't have it (yet?). I constrained statsd-client to require OCaml < 4.05.0. cc @mjambon, @mfp.


The following failed with bad checksums:

brotli 1.0, brotli 1.1, mirage 2.5.0

I didn't do anything about these.


FTR, none of these are due to Lwt. This is just to clean up the revdeps build.

@aantron
Copy link
Contributor Author

aantron commented Jun 28, 2018

I suggest merging this. There were no failures due to Lwt 4.1.0 in the original CI build, and the build is not running since I added the constraints, because some of the constrained packages have broken builds themselves.

We could split this up into two PRs to get a rebuild of Lwt against the new constraints, but I'd rather not do that. I think we will only find a few more packages that are not -safe-string-compatible, which can be done later by another package or a future release of Lwt.

@avsm
Copy link
Member

avsm commented Jun 28, 2018

Agreed. Thanks for doing all the revdeps work! By tomorrow, opam ci status should show any revdep or safe-string fallout with the results of this merged PR, which should help with subsequent PRs.

@avsm avsm merged commit 436da09 into ocaml:master Jun 28, 2018
@aantron
Copy link
Contributor Author

aantron commented Jun 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants