Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license to MIT #560

Closed
aantron opened this issue Mar 6, 2018 · 70 comments
Closed

Change license to MIT #560

aantron opened this issue Mar 6, 2018 · 70 comments

Comments

@aantron
Copy link
Collaborator

aantron commented Mar 6, 2018

Lwt is has an odd license situation, described below. To reduce confusion and make Lwt easier on users, I propose we change to the MIT license, or another such permissive license.


Please give permission

I have ccd all the contributors to Lwt further down. If you allow Lwt to change the license, please leave a comment on this issue. If you object, definitely please leave a comment :)

Anyone else is free to comment as well, of course.

I don't think we need literally every contributor to comment here. We will make public announcements, leave this open for a long while, and if all seems well, make the switch. But the more contributors comment, the clearer and cleaner the process.


Status

  • The "main" body of the license is the LGPL 2.1.
  • However, there is special text for use with OpenSSL:

    lwt/doc/COPYING

    Lines 1 to 3 in c3cdfb3

    This program is released under the LGPL version 2.1 (see the text below) with
    the additional exemption that compiling, linking, and/or using OpenSSL is
    allowed.
  • ...and another block of extraordinary text:

    lwt/doc/COPYING

    Lines 5 to 17 in c3cdfb3

    As a special exception to the GNU Library General Public License, you
    may also link, statically or dynamically, a "work that uses the Library"
    with a publicly distributed version of the Library to produce an
    executable file containing portions of the Library, and distribute
    that executable file under terms of your choice, without any of the
    additional requirements listed in clause 6 of the GNU Library General
    Public License. By "a publicly distributed version of the Library",
    we mean either the unmodified Library, or a
    modified version of the Library that is distributed under the
    conditions defined in clause 3 of the GNU Library General Public
    License. This exception does not however invalidate any other reasons
    why the executable file might be covered by the GNU Library General
    Public License.
  • In addition, Lwt_react is licensed under the 3-clause BSD license, which is what I believe this last bit of extra text refers to:

    lwt/doc/COPYING

    Lines 19 to 20 in c3cdfb3

    Some parts, when stated (as licenced under BSD3) are licenced under
    3-clauses or Modified BSD License.


cc @acieroid @agarwal @andrewray @avsm @bobbypriambodo @c-cube @cedlemo @chambart @copy @damiendoligez @dannywillems @dbuenzli @diml @dmbaturin @domsj @Drup @dsheets @edwintorok @emillon @fdopen @gabelevi @gasche @gdsfh @glondu @haesbaert @hannesm @hcarty @hhugo @hnrgrgr @iitalics @jasone @jjd27 @jpdeplaix @jsthomas @kandu @kennetpostigo @kerneis @Leonidas-from-XIV @leowzukw @malo-denielou @mfp @mor1 @nojb @olasd @orbifx @persianturtle @pqwy @pveber @raphael-proust @rgrinberg

@aantron
Copy link
Collaborator Author

aantron commented Mar 6, 2018

@yallop
Copy link
Contributor

yallop commented Mar 6, 2018

I'm fine with this change.

@domsj
Copy link
Contributor

domsj commented Mar 6, 2018

ok for me 👍

@persianturtle
Copy link
Contributor

No objection here. 👍

@c-cube
Copy link
Collaborator

c-cube commented Mar 6, 2018

fine by me! 👍

@Leonidas-from-XIV
Copy link
Contributor

I'm ok with this change 👍

@copy
Copy link
Contributor

copy commented Mar 6, 2018

I'm ok with this change.

@Drup
Copy link
Member

Drup commented Mar 6, 2018

I'm pretty sure the license is in fact standard "LGPL + linking exception" which is common in the OCaml community. I'm very confused why Lwt_react is under a difference license, though.

That being said, I don't mind the change.

@smondet
Copy link
Contributor

smondet commented Mar 6, 2018

MIT license works for me 👍

@ghost
Copy link

ghost commented Mar 6, 2018

I'd prefer if the licence remained copyleft, such as LGPL.

@kit-ty-kate
Copy link
Member

Fine by me

@jasone
Copy link
Contributor

jasone commented Mar 6, 2018

Fine by me.

@dmbaturin
Copy link
Contributor

I don't see anything strange with the current situation. OpenSSL exception will fortunately become redundant soon as they are switching to a BSD license. The "extraordinary block of text" is there to permit free distribution of binaries statically linked with the library.

However, if you think MIT or equivalent will be better for the project, I have no objections.

I feel a bit uneasy about the third clause of the 3-clause BSD license though — while it was judged to be GPL-compatible, I feel like it may be discouraging innocous and even beneficial activities such as hanging a "powered by Lwt" banner on the project website. If we are at it, can we also get rid of the third clause?

@acieroid
Copy link
Contributor

acieroid commented Mar 6, 2018

Fine by me 👍

@timbertson
Copy link
Contributor

Fine by me 👍

@seliopou
Copy link
Contributor

seliopou commented Mar 6, 2018

I'm ok with this

1 similar comment
@edwintorok
Copy link
Contributor

I'm ok with this

@hcarty
Copy link
Contributor

hcarty commented Mar 6, 2018

I'm happy with the license change 👍

@dbuenzli
Copy link
Contributor

dbuenzli commented Mar 6, 2018

Ok for me.

@kerneis
Copy link
Contributor

kerneis commented Mar 7, 2018 via email

@bobbypriam
Copy link
Collaborator

No problem for me. 👍

@whitequark
Copy link
Contributor

I'l fine with this

@rgrinberg
Copy link
Contributor

rgrinberg commented Mar 7, 2018 via email

@smithjessk
Copy link
Contributor

Sounds good.

@nojb
Copy link
Contributor

nojb commented Mar 7, 2018

Ok for me.

@ryanslade
Copy link
Contributor

Fine with me 👍

@ygrek
Copy link
Contributor

ygrek commented Mar 7, 2018

ok

@pveber
Copy link
Contributor

pveber commented Mar 7, 2018

I'm fine with the change, thanks!

@toolslive
Copy link

ok.

@gasche
Copy link
Contributor

gasche commented Mar 7, 2018

For me the main question is: the people who created Lwt (and decided on the license) and, before you, developed most of it (I would think of @vouillon and @diml, do they agree with the proposed license change? (I would expect that this was discussed with them beforehand.)

On my own contribution, I am of course fine with using the MIT license.

@avsm
Copy link
Collaborator

avsm commented Mar 8, 2018

Fine by me, and also highly appreciated!

@aantron
Copy link
Collaborator Author

aantron commented Mar 8, 2018

@dmbaturin I'd like to change Lwt_react to MIT as well, so we won't have the BSD license at all anymore.

@haesbaert Indeed, I usually wouldn't expect to be asked about most contributions I've made to projects. But on the other hand, some people have made considerable contributions to Lwt, without making or being made aware of any statement or agreement about copyright, and/or forgetting (both contributor and reviewer) to change or create the license header, etc. So there seems to be a considerable gray area. It seems reasonable to check thoroughly for objections and other opinions, as suggested by @kerneis and @dmbaturin, even if we expect that most contributors generously don't believe themselves to have rights over their contributions.

@agarwal
Copy link
Contributor

agarwal commented Mar 8, 2018

I'm okay with the change.

@kandu
Copy link
Contributor

kandu commented Mar 9, 2018

fine by me

@andrewray
Copy link
Contributor

andrewray commented Mar 9, 2018 via email

@stijn-devriendt
Copy link
Contributor

Approved by our legal team.
Otherwise, fine by me too.

@damiendoligez
Copy link
Contributor

OK for me for the license change.

@dmbaturin I was once asked to sign a Contributor Licence Agreement for a contribution that consisted entirely of removing one character from a source file. Do you think such a contribution is (or should be) covered by copyright? I don't.

@dmbaturin
Copy link
Contributor

@damiendoligez People like SCO are constantly trying to push it as far as they can, and in the civil law it's the defendant who has to prove the claim wrong — I can see why people may want to stay completely on the safe side. Anyway, my own position is more of "be conservative in what you do and liberal in what you accept". I'm fine with my own contributions to Lwt being relicensed whether they are big or small, but as a maintainer I wouldn't assume that everyone else will be.

Still, it's an interesting philosophical question, how physical size of a contribution relates to its importance. A person who fixed a remotely exploitable vulnerability by removing one character might have contributed more to the project than someone who wrote thousands lines of useful but non-essential code — whether the change itself can be copyrighted or not, I would be inclined to ask their opinion before making license changes.

@rneswold
Copy link
Contributor

rneswold commented Mar 9, 2018

Fine by me.

@pqwy
Copy link
Contributor

pqwy commented Apr 18, 2018

I don't think any of my code is in Lwt, so I also don't believe I have rights over it.

I'm fine with this change either way.

@Richard-Degenne
Copy link
Contributor

Richard-Degenne commented Apr 19, 2018

Sorry I haven't checked out Lwt in a while.

It's all right with me! :)

@vouillon
Copy link
Member

I'm okay with the change.

@olasd
Copy link
Contributor

olasd commented Apr 19, 2018

Hi,

I'm fine with the change.

Thanks!
Nicolas

@dsheets
Copy link
Contributor

dsheets commented Apr 21, 2018

This is great news. I'm happy with this change.

@chambart
Copy link
Contributor

I'm ok, no objections.

@aantron
Copy link
Collaborator Author

aantron commented Apr 23, 2018

Thank you all, the license is now MIT :)

The final status was:

  • Almost all contributors and organizations involved in Lwt development agreed.

  • Some of the agreements were communicated by email or in Gitter.

  • There were no objections.

  • A few (~5) contributors did not respond, but in each of those cases, several of the following hold:

    • The contributions are of such a nature, that we think most contributors would not consider themselves to have rights over them. Precedent seems to agree at least in the United States.
    • The contributions have since been largely overwritten by other contributions.
    • The contributions were to parts of Lwt that have since been factored out into other repos, whose licenses we aren't changing (lwt_camlp4, lwt_ssl, etc).

Since we didn't get explicit assent from a few contributors, however, I think it's best not to apply MIT retroactively to past Lwt releases. In some of them, the contributions we don't have assent for were still current. So, the MIT license applies to the next release of Lwt, and to master starting from the commit that closed this issue.

@ZackC
Copy link
Contributor

ZackC commented Apr 23, 2018 via email

@aantron
Copy link
Collaborator Author

aantron commented Apr 23, 2018

Thank you nonetheless :)

@tychota
Copy link

tychota commented Apr 24, 2018

The readme badge still display lgpl, i think.

@tychota
Copy link

tychota commented Apr 24, 2018

#582 - > update the readme badge too.

@AkihiroSuda
Copy link

Could you release 4.0.2 with the new license?

@aantron
Copy link
Collaborator Author

aantron commented Jun 23, 2018

@AkihiroSuda Yes, will do so in the coming days. I guess it will be 4.1.0, because we added a few things.

@aantron
Copy link
Collaborator Author

aantron commented Jun 29, 2018

@AkihiroSuda Lwt 4.1.0 is now out. I'll make a broader announcement shortly as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests