Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune (1.3.0) #12693

Merged
merged 1 commit into from
Sep 25, 2018
Merged

[new release] dune (1.3.0) #12693

merged 1 commit into from
Sep 25, 2018

Conversation

rgrinberg
Copy link
Member

CHANGES:

@camelus
Copy link
Contributor

camelus commented Sep 23, 2018

☀️ All lint checks passed f38ff31
  • These packages passed lint tests: dune.1.3.0

☀️ Installability check (9720 → 9722)
  • these releases can now be installed, well done (1): modelica_ml.0.2.0
  • new installable packages (1): dune.1.3.0

@mseri
Copy link
Member

mseri commented Sep 24, 2018

The PR is in opam 1.2 format. Can you update it to opam2?

@@ -0,0 +1,18 @@
opam-version: "1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a 2.0 format PR for the master branch

@emillon
Copy link
Contributor

emillon commented Sep 24, 2018

@rgrinberg the steps to convert are:

@rgrinberg
Copy link
Member Author

@emillon I was planning to just re-submit with the new dune-release. It should work with opam 2.0

@emillon
Copy link
Contributor

emillon commented Sep 24, 2018

works as well!

CHANGES:

- Support colors on Windows (ocaml/dune#1290, @diml)

- Allow `dune.configurator` and `base` to be used together (ocaml/dune#1291, fix
  ocaml/dune#1167, @diml)

- Support interrupting and restarting builds on file changes (ocaml/dune#1246,
  @kodek16)

- Fix findlib-dynload support with byte mode only (ocaml/dune#1295, @bobot)

- Make `dune rules -m` output a valid makefile (ocaml/dune#1293, @diml)

- Expand variables in `(targets ..)` field (ocaml/dune#1301, ocaml/dune#1320, fix ocaml/dune#1189, @nojb,
  @rgrinberg, @diml)

- Fix a race condition on Windows that was introduced in 1.2.0
  (ocaml/dune#1304, fix ocaml/dune#1303, @diml)

- Fix the generation of .merlin files to account for private modules
  (@rgrinberg, fix ocaml/dune#1314)

- Exclude the local opam switch directory (`_opam`) from the list of watched
  directories (ocaml/dune#1315, @dysinger)

- Fix compilation of the module generated for `findlib.dynload`
  (ocaml/dune#1317, fix ocaml/dune#1310, @diml)

- Lift restriction on `copy_files` and `copy_files#` stanzas that files to be
  copied should be in a subdirectory of the current directory.
  (ocaml/dune#1323, fix ocaml/dune#911, @nojb)
@rgrinberg
Copy link
Member Author

Okay, I think it's using the 2.0 format now.

@mseri
Copy link
Member

mseri commented Sep 25, 2018

Looks good now. All the Revdeps errors seem to be independent of this

@mseri mseri merged commit 17f544f into ocaml:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants