Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dependency on dune-configurator for all packages that use dune.configurator #14851

Merged
merged 3 commits into from Sep 19, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2019

We are planning to split dune.configurator as a separate dune-configurator package in Dune 2.0.0. The dune.configurator name will still exist for backward compatibility reason, however packages that use it must declare an additional dependency on dune-configurator in order to be compatible with Dune >= 2.0.0.

In preparation of this, this PR adds an empty dune-configurator.1.0.0 that depends on Dune < 2.0.0 and adds it as a dependency of all packages that use dune.configurator.

…configurator

Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
@ghost
Copy link
Author

ghost commented Sep 19, 2019

The failures are unrelated.

Co-Authored-By: Kate <kit.ty.kate@disroot.org>
@camelus
Copy link
Contributor

camelus commented Sep 19, 2019

🌩️ opam-lint errors a735d34
  • ocamlfuse.2.7.1-cvs6 has errors:

    • error 52: Package is needlessly flagged "light-uninstall", since it has no remove instructions
  • dune-configurator.1.0.0 has some warnings:

    • warning 25: Missing field 'authors'
    • warning 35: Missing field 'homepage'
    • warning 36: Missing field 'bug-reports'
    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • iter.1.2.1 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • These packages passed lint tests: ahrocksdb.0.2.0, ahrocksdb.0.2.1, ahrocksdb.0.2.2, async_ssl.v0.12.0, base.v0.12.1, base.v0.12.2, bwrap.0.1, cairo2.0.6.1, cairo2.0.6, containers.2.4.1, containers.2.4, containers.2.5, containers.2.6.1, containers.2.6, crlibm.0.3, crlibm.0.4, fftw3.0.8.2, fftw3.0.8.3, fiat-p256.0.1.0, fiat-p256.0.2.0, freetds.0.7, glfw-ocaml.3.2.1-1, glfw-ocaml.3.2.1-2, gsl.1.24.0, hdf5.0.1.5, hidapi.1.1.1, hidapi.1.1, interval_base.1.5.1, interval_base.1.5, interval_crlibm.1.5.1, interval_crlibm.1.5, io-page.2.1.0, io-page.2.2.0, io-page.2.3.0, jst-config.v0.12.0, lablgtk3.3.0.beta4, lablgtk3.3.0.beta5, lablgtk3.3.0.beta6, lacaml.11.0.2, lacaml.11.0.3, lacaml.11.0.4, lbfgs.0.9.1, lbfgs.0.9.2, lbfgs.0.9.3, links-postgresql.0.9, links-sqlite3.0.9, links.0.9, lwt.4.3.0, mesh-easymesh.0.9.5, mesh.0.9.5, mindstorm-lwt.0.8, mindstorm.0.8, mirage-clock-freestanding.2.0.0, mirage-clock-lwt.2.0.0, mirage-clock.2.0.0, mssql.1.1, odepack.0.6.9, odepack.0.7, owl-base.0.5.0, owl-base.0.6.0, owl.0.5.0, owl.0.6.0, pcre.7.3.5, pcre.7.4.0, pcre.7.4.1, postgresql.4.4.1, postgresql.4.4.2, postgresql.4.5.0, ppx_cstubs.0.1.0, ppx_cstubs.0.2.0, ppx_cstubs.0.2.1, qrencode.0.2, sqlite3.4.4.1, ssl.0.5.6, ssl.0.5.7, ssl.0.5.8, ssl.0.5.9, tcpip.3.7.6, tcpip.3.7.7, tcpip.3.7.8, tensorflow.0.0.11, torch.0.1, torch.0.2, torch.0.3, torch.0.4, torch.0.5, torch.0.6, yaml.1.0.0, yaml.2.0.0, yaml.2.0.1


☀️ Installability check (+1)
  • new installable packages (1): dune-configurator.1.0.0

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 9c9cb58 into ocaml:master Sep 19, 2019
aantron added a commit to ocsigen/lwt that referenced this pull request Sep 26, 2019
aantron added a commit to ocsigen/lwt that referenced this pull request Sep 26, 2019
aantron added a commit to ocsigen/lwt that referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants