Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain some package in anticipation of dune 2.0 #15206

Merged
merged 34 commits into from
Nov 4, 2019

Conversation

kit-ty-kate
Copy link
Member

I went through a custom run of opam-health-check (before and after #15158) and added a few easy constraints where needed.

cc @rgrinberg (I also added a constraint in jbuilder.transition to be more complete even though the conflicts is already in dune.2.0.0)

The reason for each breakage is stated in each individual commit messages.

@mseri
Copy link
Member

mseri commented Nov 4, 2019

Thanks @kit-ty-kate that's an error only on the opam file for md2mld, they both use dune. Apologies for not noticing before. I'll send a PR to fix it

mseri added a commit to mseri/opam-repository that referenced this pull request Nov 4, 2019
Spotted by @kit-ty-kate ocaml#15206

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@Leonidas-from-XIV
Copy link
Contributor

Thanks for the PR. As a co-maintainer of zmq, what configurator now? I haven't seen any note on the draft1 changelog of dune about the change.

gildor478 added a commit to gildor478/ocaml-gettext that referenced this pull request Nov 4, 2019
@gildor478
Copy link
Member

LGTM for gettext-stub, I am adding it to ocaml-gettext as well.

@kit-ty-kate
Copy link
Member Author

Thanks for the PR. As a co-maintainer of zmq, what configurator now? I haven't seen any note on the draft1 changelog of dune about the change.

Mmh, that's true, there is no mention of dune-configurator in the changelog. Here is a related PR for a little bit of context: #14851

@camelus
Copy link
Contributor

camelus commented Nov 4, 2019

🌩️ opam-lint errors 8a7fd08
  • lbvs_consent.2.0.0 has errors:

    • error 57: Synopsis and description must not be both empty
  • mccs.1.1+9 has errors:

    • error 57: Synopsis and description must not be both empty
  • csv.2.1 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • dokeysto.3.0.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • dokeysto_camltc.3.0.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • ocaml-migrate-parsetree.1.1.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • rtop.3.3.5 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • rtop.3.3.7 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • rtop.3.4.0 has some warnings:

    • warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
  • These packages passed lint tests: blake2.0.1, blake2.0.2, bun.0.3.3, bytearray.1.0.0, encore.0.2, ezsqlite.0.4.1, ezsqlite.0.4, gemini.0.1, gemini.0.2.0, get_line.4.0.1, get_line.5.0.0, get_line.6.0.0, gettext-stub.0.4.1, hacl.0.1, hts_shrink.1.0.0, jbuilder.transition, lbvs_consent.2.0.1, magic-mime.1.1.1, mccs.1.1+5, mccs.1.1+6, mccs.1.1+8, md2mld.0.2.0, md2mld.0.3.0, mirage-clock-unix.3.0.0, ocaml-migrate-parsetree.1.0.11, odoc.1.3.0, open.0.2.2, orsvm_e1071.3.0.2, ppx_deriving_cmdliner.0.4.1, ppxlib.0.2.1, ppxlib.0.3.0, reason.3.3.5, reason.3.3.7, reason.3.4.0, relit-reason.0.0.1, relit-reason.0.0.2, rosetta.0.1.0, setcore.1.0.1, tensorflow.0.0.11, uecc.0.1, uri.2.0.0, uri.2.1.0, yuscii.0.2.0, zmq.5.1.1, zmq.5.1.2


☀️ Installability check (+0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants