Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] routes (0.6.0) #15560

Closed
wants to merge 1 commit into from
Closed

[new release] routes (0.6.0) #15560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/routes/routes.0.6.0/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
opam-version: "2.0"
maintainer: "Anurag Soni <anurag@sonianurag.com>"
authors: [ "Anurag Soni <anurag@sonianurag.com>" ]
license: "BSD-3-clause"
homepage: "https://github.com/anuragsoni/routes"
bug-reports: "https://github.com/anuragsoni/routes/issues"
dev-repo: "git+https://github.com/anuragsoni/routes.git"
doc: "https://anuragsoni.github.io/routes/"
tags: [ "router" "http" ]
build: [
["dune" "subst"] {pinned}
["dune" "build" "-p" name "-j" jobs]
["dune" "runtest" "-p" name "-j" jobs] {with-test}
]
depends: [
"ocaml" {>= "4.05"}
"dune" { >= "1.1" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that (using fmt 1.1) works with dune 1.1 and does not require 1.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. My understanding was that the version needs to match the dune language version in the dune-project file. I’ll check the docs again to confirm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently dune extensions do not check for a matching dune version number (see ocaml/dune#2957) and according to ocaml/dune#1821, fmt 1.1 has been added in dune.1.7.0. So I believe your package requires at least dune 1.7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing those links. I think if I need to change the dune version constraint, I’ll go over the dune docs to see if there are any other extension that I’d like to use. Or see if I stop using the fmt extension. I’ll close this pull request for now and revisit this once I’ve figured out which dune extensions I need.

"alcotest" {with-test}
"mdx" { with-test }
]
synopsis: "Typed routing for OCaml applications"
description: """
routes provides combinators for adding typed routing
to OCaml applications. The core library will be independent
of any particular web framework or runtime. It does
path based dispatch from a target url to a user
provided handler.
"""
url {
src:
"https://github.com/anuragsoni/routes/releases/download/0.6.0/routes-0.6.0.tbz"
checksum: [
"sha256=da156ecc5400b425269f85cac99c270f8645487acbe025dc5a85ed6185b547c1"
"sha512=f00757206593f5b5060bf8d90bb57cb65a58ea68c642a3b17e777804739a7442ed51303036d86dd7e8615bac468e5040101ed9b71159bd9b4a065e43724c5088"
]
}