Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions should check for the lowest version of dune they are available in #2957

Closed
kit-ty-kate opened this issue Dec 7, 2019 · 1 comment · Fixed by #3270 or ocaml/opam-repository#16170
Assignees

Comments

@kit-ty-kate
Copy link
Member

Looking at some failure logs, I came across this one:

#=== ERROR while compiling ppxlib.0.10.0 ======================================#
# context              2.0.5 | linux/x86_64 | ocaml-base-compiler.4.04.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.04.2/.opam-switch/build/ppxlib.0.10.0
# command              ~/.opam/4.04.2/bin/dune build -p ppxlib -j 71
# exit-code            1
# env-file             ~/.opam/log/ppxlib-6-f9b82b.env
# output-file          ~/.opam/log/ppxlib-6-f9b82b.out
### output ###
# File "dune-project", line 4, characters 7-13:
# 4 | (using cinaps 1.0)
#            ^^^^^^
# Error: Unknown extension "cinaps".

The problem is that dune 1.6 is installed but cinaps is only available in dune 1.11 and above.
However the dune-project file is as follow:

(lang dune 1.0)
(name ppxlib)
(using cinaps 1.0)

In my opinion dune should be able to raise an error if such dune-project gets detected. In that case an error should be raised if (lang dune ...) is below 1.11.

@ghost
Copy link

ghost commented Dec 10, 2019

Agreed. So we could do this right now with some ad-hoc code, but to make things smoother moving forward I'd rather we come up with a general solution right from the start. I haven't put much thought into it, but I guess it involves declaring dependencies between extension versions and the main language version.

@emillon emillon self-assigned this Jan 15, 2020
@voodoos voodoos self-assigned this Mar 10, 2020
@voodoos voodoos mentioned this issue Mar 16, 2020
1 task
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Apr 10, 2020
…lugin, dune-private-libs and dune-glob (2.5.0)

CHANGES:

- Add a `--release` option meaning the same as `-p` but without the
  package filtering. This is useful for custom `dune` invocation in opam
  files where we don't want `-p` (ocaml/dune#3260, @diml)

- Fix a bug introduced in 2.4.0 causing `.bc` programs to be built
  with `-custom` by default (ocaml/dune#3269, fixes ocaml/dune#3262, @diml)

- Allow contexts to be defined with local switches in workspace files (ocaml/dune#3265,
  fix ocaml/dune#3264, @rgrinberg)

- Delay expansion errors until the rule is used to build something (ocaml/dune#3261, fix
  ocaml/dune#3252, @rgrinberg, @diml)

- [coq] Support for theory dependencies and compositional builds using
  new field `(theories ...)` (ocaml/dune#2053, @ejgallego, @rgrinberg)

- From now on, each version of a syntax extension must be explicitely tied to a
  minimum version of the dune language. Inconsistent versions in a
  `dune-project` will trigger a warning for version <=2.4 and an error for
  versions >2.4 of the dune language. (ocaml/dune#3270, fixes ocaml/dune#2957, @voodoos)

- [coq] Bump coq lang version to 0.2. New coq features presented this release
  require this version of the coq lang. (ocaml/dune#3283, @ejgallego)

- Prevent installation of public executables disabled using the `enabled_if` field.
  Installation will now simply skip such executables instead of raising an
  error. (ocaml/dune#3195, @voodoos)

- `dune upgrade` will now try to upgrade projects using versions <2.0 to version
  2.0 of the dune language. (ocaml/dune#3174, @voodoos)

- Add a `top` command to integrate dune with any toplevel, not just
  utop. It is meant to be used with the new `#use_output` directive of
  OCaml 4.11 (ocaml/dune#2952, @mbernat, @diml)

- Allow per-package `version` in generated `opam` files (ocaml/dune#3287, @toots)

- [coq] Introduce the `coq.extraction` stanza. It can be used to extract OCaml
  sources (ocaml/dune#3299, fixes ocaml/dune#2178, @rgrinberg)

- Load ppx rewriters in dune utop and add pps field to toplevel stanza. Ppx
  extensions will now be usable in the toplevel
  (ocaml/dune#3266, fixes ocaml/dune#346, @stephanieyou)

- Add a `(subdir ..)` stanza to allow evaluating stanzas in sub directories.
  (ocaml/dune#3268, @rgrinberg)

- Fix a bug preventing one from running inline tests in multiple modes
  (ocaml/dune#3352, @diml)

- Allow the use of the `%{profile}` variable in the `enabled_if` field of the
  library stanza. (ocaml/dune#3344, @mrmr1993)

- Allow the use of `%{ocaml_version}` variable in `enabled_if` field of the
  library stanza. (ocaml/dune#3339, @voodoos)

- Fix dune build freezing on MacOS when cache is enabled. (ocaml/dune#3249, fixes #ocaml/dune#2973,
  @artempyanykh)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants