Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag disable_dynamically_linked_foreign_archives seems to default to "true", in switches #3262

Closed
corwin-of-amber opened this issue Mar 14, 2020 · 2 comments · Fixed by ocaml/opam-repository#16170
Closed

Flag disable_dynamically_linked_foreign_archives seems to default to "true", in switches #3262

corwin-of-amber opened this issue Mar 14, 2020 · 2 comments · Fixed by ocaml/opam-repository#16170

Comments

@corwin-of-amber
Copy link

Expected Behavior

Bytecode executables that depend on foreign libraries should use dynamic loading by default.

Actual Behavior

When defining a context in dune-workspace, Dune falls back to linking with -custom. Adding (disable_dynamically_linked_foreign_archives false) reproduces the normal behavior (as it was in Dune 2.3.1).

Reproduction

Extract this tarball and run dune build --verbose a.bc.
dune-custom-bug.tar.gz

Specifications

  • Version of dune (output of dune --version): 2.4.0
  • Version of ocaml (output of ocamlc --version): 4.08.1
  • Operating system (distribution and version): macOS 10.15

Additional information
@corwin-of-amber
Copy link
Author

May be relevant: 038564b

@ghost
Copy link

ghost commented Mar 16, 2020

Ah indeed, the meaning was reversed but not the default value.

@ghost ghost closed this as completed in e82710f Mar 16, 2020
@rgrinberg rgrinberg mentioned this issue Apr 10, 2020
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Apr 10, 2020
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-action-p…
7424c3d 
…lugin, dune-private-libs and dune-glob (2.5.0)

CHANGES:

- Add a `--release` option meaning the same as `-p` but without the
  package filtering. This is useful for custom `dune` invocation in opam
  files where we don't want `-p` (ocaml/dune#3260, @diml)

- Fix a bug introduced in 2.4.0 causing `.bc` programs to be built
  with `-custom` by default (ocaml/dune#3269, fixes ocaml/dune#3262, @diml)

- Allow contexts to be defined with local switches in workspace files (ocaml/dune#3265,
  fix ocaml/dune#3264, @rgrinberg)

- Delay expansion errors until the rule is used to build something (ocaml/dune#3261, fix
  ocaml/dune#3252, @rgrinberg, @diml)

- [coq] Support for theory dependencies and compositional builds using
  new field `(theories ...)` (ocaml/dune#2053, @ejgallego, @rgrinberg)

- From now on, each version of a syntax extension must be explicitely tied to a
  minimum version of the dune language. Inconsistent versions in a
  `dune-project` will trigger a warning for version <=2.4 and an error for
  versions >2.4 of the dune language. (ocaml/dune#3270, fixes ocaml/dune#2957, @voodoos)

- [coq] Bump coq lang version to 0.2. New coq features presented this release
  require this version of the coq lang. (ocaml/dune#3283, @ejgallego)

- Prevent installation of public executables disabled using the `enabled_if` field.
  Installation will now simply skip such executables instead of raising an
  error. (ocaml/dune#3195, @voodoos)

- `dune upgrade` will now try to upgrade projects using versions <2.0 to version
  2.0 of the dune language. (ocaml/dune#3174, @voodoos)

- Add a `top` command to integrate dune with any toplevel, not just
  utop. It is meant to be used with the new `#use_output` directive of
  OCaml 4.11 (ocaml/dune#2952, @mbernat, @diml)

- Allow per-package `version` in generated `opam` files (ocaml/dune#3287, @toots)

- [coq] Introduce the `coq.extraction` stanza. It can be used to extract OCaml
  sources (ocaml/dune#3299, fixes ocaml/dune#2178, @rgrinberg)

- Load ppx rewriters in dune utop and add pps field to toplevel stanza. Ppx
  extensions will now be usable in the toplevel
  (ocaml/dune#3266, fixes ocaml/dune#346, @stephanieyou)

- Add a `(subdir ..)` stanza to allow evaluating stanzas in sub directories.
  (ocaml/dune#3268, @rgrinberg)

- Fix a bug preventing one from running inline tests in multiple modes
  (ocaml/dune#3352, @diml)

- Allow the use of the `%{profile}` variable in the `enabled_if` field of the
  library stanza. (ocaml/dune#3344, @mrmr1993)

- Allow the use of `%{ocaml_version}` variable in `enabled_if` field of the
  library stanza. (ocaml/dune#3339, @voodoos)

- Fix dune build freezing on MacOS when cache is enabled. (ocaml/dune#3249, fixes #ocaml/dune#2973,
  @artempyanykh)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@corwin-of-amber