Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --release option #3260

Merged
3 commits merged into from Mar 16, 2020
Merged

Add a --release option #3260

3 commits merged into from Mar 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2020

-p means --only-packages plus a lot of other useful things to put dune in "reproducible release mode", such as:

  • not reading the configuration file
  • disabling root detection
  • ...

Sometimes, we want the reproducible release mode without the package filtering. So this PR introduce a new option --release that means the same thing as -p except the package filtering. Or put it another way, -p x is now a shorthand for --release --only-packages x.

@jeremiedimino
Add a --release option
6c6f929 
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
@emillon
Copy link
Collaborator

emillon commented Mar 16, 2020

--release sounds a lot like --profile release, but it's also different so it might be a source of confusion. If that's properly documented, that might be ok though.

@rgrinberg rgrinberg requested review from snowleopard and removed request for snowleopard March 16, 2020 11:23
rgrinberg
rgrinberg approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I agree that it's a bit confusing wrt --profile release. We should clarify that profiles are a separate thing from the true release mode.

@ghost
Copy link
Author

ghost commented Mar 16, 2020

Yh, I was wondering about that as well. Would --release-mode be clearer?

@rgrinberg
Copy link
Member

Tbh, --release still sounds better. I'm not sure --release-mode is any clearer to users.

@emillon
Copy link
Collaborator

emillon commented Mar 16, 2020

Yes, I agree.

ghost
ghost commented Mar 16, 2020
View reviewed changes
@ghost ghost merged commit bf5f954 into ocaml:master Mar 16, 2020
@ghost
Copy link
Author

ghost commented Mar 16, 2020

Alright, let's stick to --release then. Regarding the doc, maybe the part of the manual that mention -p could be improved. I'll have a look.

@rgrinberg rgrinberg mentioned this pull request Apr 10, 2020
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Apr 10, 2020
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-action-p…
7424c3d 
…lugin, dune-private-libs and dune-glob (2.5.0)

CHANGES:

- Add a `--release` option meaning the same as `-p` but without the
  package filtering. This is useful for custom `dune` invocation in opam
  files where we don't want `-p` (ocaml/dune#3260, @diml)

- Fix a bug introduced in 2.4.0 causing `.bc` programs to be built
  with `-custom` by default (ocaml/dune#3269, fixes ocaml/dune#3262, @diml)

- Allow contexts to be defined with local switches in workspace files (ocaml/dune#3265,
  fix ocaml/dune#3264, @rgrinberg)

- Delay expansion errors until the rule is used to build something (ocaml/dune#3261, fix
  ocaml/dune#3252, @rgrinberg, @diml)

- [coq] Support for theory dependencies and compositional builds using
  new field `(theories ...)` (ocaml/dune#2053, @ejgallego, @rgrinberg)

- From now on, each version of a syntax extension must be explicitely tied to a
  minimum version of the dune language. Inconsistent versions in a
  `dune-project` will trigger a warning for version <=2.4 and an error for
  versions >2.4 of the dune language. (ocaml/dune#3270, fixes ocaml/dune#2957, @voodoos)

- [coq] Bump coq lang version to 0.2. New coq features presented this release
  require this version of the coq lang. (ocaml/dune#3283, @ejgallego)

- Prevent installation of public executables disabled using the `enabled_if` field.
  Installation will now simply skip such executables instead of raising an
  error. (ocaml/dune#3195, @voodoos)

- `dune upgrade` will now try to upgrade projects using versions <2.0 to version
  2.0 of the dune language. (ocaml/dune#3174, @voodoos)

- Add a `top` command to integrate dune with any toplevel, not just
  utop. It is meant to be used with the new `#use_output` directive of
  OCaml 4.11 (ocaml/dune#2952, @mbernat, @diml)

- Allow per-package `version` in generated `opam` files (ocaml/dune#3287, @toots)

- [coq] Introduce the `coq.extraction` stanza. It can be used to extract OCaml
  sources (ocaml/dune#3299, fixes ocaml/dune#2178, @rgrinberg)

- Load ppx rewriters in dune utop and add pps field to toplevel stanza. Ppx
  extensions will now be usable in the toplevel
  (ocaml/dune#3266, fixes ocaml/dune#346, @stephanieyou)

- Add a `(subdir ..)` stanza to allow evaluating stanzas in sub directories.
  (ocaml/dune#3268, @rgrinberg)

- Fix a bug preventing one from running inline tests in multiple modes
  (ocaml/dune#3352, @diml)

- Allow the use of the `%{profile}` variable in the `enabled_if` field of the
  library stanza. (ocaml/dune#3344, @mrmr1993)

- Allow the use of `%{ocaml_version}` variable in `enabled_if` field of the
  library stanza. (ocaml/dune#3339, @voodoos)

- Fix dune build freezing on MacOS when cache is enabled. (ocaml/dune#3249, fixes #ocaml/dune#2973,
  @artempyanykh)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emillon @rgrinberg @jeremiedimino