Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] anthill (0.1) #16151

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

martindemello
Copy link
Contributor

Word search library and utility

CHANGES:
  • Initial release

CHANGES:

* Initial release
@camelus
Copy link
Contributor

camelus commented Apr 6, 2020

Commit: 50be5c0

Hello @martindemello! I believe this is your first contribution here. Please be nice, reviewers!

☀️ All lint checks passed 50be5c0
  • These packages passed lint tests: anthill.0.1

☀️ Installability check (+1)
  • new installable packages (1): anthill.0.1

@martindemello
Copy link
Contributor Author

it's my first opam package, yes :) happy to fix whatever details i got wrong!

@kit-ty-kate
Copy link
Member

Your package looks good apart from the tiny change needed in the dependencies.
Dune should not be tagged as a build dependency due to a long-standing issue in dune (see ocaml/dune#2147 and #14266)

Also one personal side-note from myself: when starting a project I'd recommand starting with the base library rather than core if you want to stay with Jane-Street style libraries. core pulls a lot of unnecessary dependencies, in most cases you just need base (I think they mostly have a compatible interface).

Thanks!

@kit-ty-kate
Copy link
Member

Oh also could you return the fix I made upstream?

@kit-ty-kate kit-ty-kate merged commit 4623f1b into ocaml:master Apr 6, 2020
@kit-ty-kate
Copy link
Member

Oh.. nevermind something is wrong. I'm reverting. Your package does not install anything due to ocaml/dune#2882

@martindemello
Copy link
Contributor Author

should i send a new pull request with your fixes merged in?

@kit-ty-kate
Copy link
Member

kit-ty-kate commented Apr 6, 2020

yes please! you might also have to retag the 0.1 (or a new) version though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants