-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] relax parsing of dune-package files #2147
Comments
Apart from the interaction with opam, this issue also affects dune itself when using the
Calling dune with the following command:
Results in the following error:
The issue is that the version of dune used during the first call is not the latest one and fails if some development version is used or simply if the current version of dune used is not the highest across of all the opam switches used. |
Having dune as a |
Co-authored-by: Marcello Seri <mseri@users.noreply.github.com>
I remember talking about this with Jeremie in private and I'm pleased to say that I convinced him that this was a bad idea. Let's keep dune-package as an implementation detail and leave all the optimization to dune's cache. |
I don't exactly know why, but if we have it the linter of the OPAM repository gets upset with us with: > Warning in `morbig.0.10.4`: The package tagged dune as a build dependency. Due to a bug in dune (ocaml/dune#2147) this should never be the case. Please remove the `{build}` tag from its filter.
Currently, the following scenario is annoying:
The dune installed in step 3 cannot read
dune-package
installed by dune in step 1. This mean that we have to reinstall all the packages installed in step 2.I propose to improve this scenario as follow: when dune v.x read a
dune-package
file with(lang dune v.y)
andy > x
, then dune can still read the file but will silently ignore any field it doesn't understand. For this to work well, we must be conservative in the encoding ofdune-package
between minor versions. i.e., we can add new fields but we cannot rename them.The text was updated successfully, but these errors were encountered: