Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ppx_seq.0.2.0 #20579

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Update ppx_seq.0.2.0 #20579

merged 3 commits into from
Jan 29, 2022

Conversation

hyphenrf
Copy link
Contributor

Update features lower OCaml version bounds and perf annotations for compilers that support it.

hyphenrf and others added 3 commits January 29, 2022 01:09
Update features lower OCaml version bounds and perf annotations for compilers that support it.
@kit-ty-kate
Copy link
Member

Dune is not a build dependency (see ocaml/dune#2147)
Ppxlib is not a build dependency either as it is used as library to create this library (ppxs are libraries) and thus will need to be rebuilt everytime ppxlib is.

@kit-ty-kate kit-ty-kate merged commit 685601a into ocaml:master Jan 29, 2022
@kit-ty-kate
Copy link
Member

Thanks! Could you return the fix in the opam file upstream so it can be taken into account for next time?

@hyphenrf
Copy link
Contributor Author

Thanks for the pointers @kit-ty-kate, I'm on it!

hyphenrf added a commit to hyphenrf/ppx_seq that referenced this pull request Jan 30, 2022
@hyphenrf hyphenrf deleted the patch-1 branch January 30, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants