Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package memprof-limits.0.1 #16403

Merged
merged 2 commits into from
May 12, 2020

Conversation

gadmm
Copy link
Contributor

@gadmm gadmm commented May 10, 2020

memprof-limits.0.1

Memory limits based on memprof
Memprof-limits provides per-thread global memory limits, and
per-thread allocation limits à la Haskell, compatible with systhreads.

Per-thread global memory limits let you bound the memory consumption
of specific parts of your program, in terms of memory used by the
whole program.

Per-thread allocation limits let you bound the execution of parts of
the program measured in number of allocation, analogous to the same
feature in Haskell. Allocation limits count allocations but not
deallocations, and is therefore a measure of the work done which can
be more suitable than execution time.

The implementation uses memprof with a low sampling rate that does not
affect performance. A reimplementation of the memprof interface
compatible with memprof-limits running at the same time is provided
for profiling needs.

THIS PACKAGE IS EXPERIMENTAL



🐫 Pull-request generated by opam-publish v2.0.2

@camelus
Copy link
Contributor

camelus commented May 10, 2020

Commit: 2bf6d04

Hello @gadmm! I believe this is your first contribution here. Please be nice, reviewers!

☀️ All lint checks passed 2bf6d04
  • These packages passed lint tests: memprof-limits.0.1

☀️ Installability check (+1)
  • new installable packages (1): memprof-limits.0.1

@gadmm
Copy link
Contributor Author

gadmm commented May 11, 2020

Thanks @kit-ty-kate, I have already upstreamed your fix!

@kit-ty-kate
Copy link
Member

thanks!

@kit-ty-kate kit-ty-kate merged commit dbcc40e into ocaml:master May 12, 2020
@gadmm gadmm deleted the opam-publish-memprof-limits.0.1 branch May 12, 2020 00:11
@gadmm
Copy link
Contributor Author

gadmm commented Jul 26, 2021

Hi @kit-ty-kate, I see many opam files where the dune dependency is tagged with the build variable like I did initially. I removed it based on your correction but I am wondering if I should add it back. What was the reason to remove it?

@kit-ty-kate
Copy link
Member

The reason behind this is a long standing bug in dune: ocaml/dune#2147.

What packages did you see where dune is tagged as a build dependency? I can't find any in opam-repository (if there is this is something that we should fix)

@gadmm
Copy link
Contributor Author

gadmm commented Jul 26, 2021

I grepped my local download of the opam repository, which I usually use instead for auditing OCaml code.

  • I downloaded it up to two years ago, so maybe it was in the meanwhile that you removed all the build tags?
  • These are the upstream opam files, not the ones on opam-repository, so maybe the fixes were not upstreamed?

If this does not explain the difference then I can send the list of what I have found.

@kit-ty-kate
Copy link
Member

I downloaded it up to two years ago, so maybe it was in the meanwhile that you removed all the build tags?

Yes indeed, this was done two years ago in #14266

These are the upstream opam files, not the ones on opam-repository, so maybe the fixes were not upstreamed?

Most likely

@gadmm
Copy link
Contributor Author

gadmm commented Jul 26, 2021

Ok thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants