Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package integers_stubs_js.1.0 #17110

Merged

Conversation

mrmr1993
Copy link
Contributor

@mrmr1993 mrmr1993 commented Sep 2, 2020

integers_stubs_js.1.0

Javascript stubs for the integers library in js_of_ocaml
Javascript stubs for the integers library in js_of_ocaml.



🐫 Pull-request generated by opam-publish v2.0.2

@camelus
Copy link
Contributor

camelus commented Sep 2, 2020

Commit: f910add

Hello @mrmr1993! I believe this is your first contribution here. Please be nice, reviewers!

☀️ All lint checks passed f910add
  • These packages passed lint tests: integers_stubs_js.1.0

☀️ Installability check (+1)
  • new installable packages (1): integers_stubs_js.1.0

@kit-ty-kate
Copy link
Member

Dune is not compatible with the the {build} tag (see ocaml/dune#2147). Could you return the fix upstream so that it can be taken into account for future releases?

Otherwise it looks good. Thanks.

@kit-ty-kate kit-ty-kate merged commit beb92c4 into ocaml:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants