Package pla.2.1 #22419
Package pla.2.1 #22419
Conversation
packages/pla/pla.2.1/opam
Outdated
| "ocaml" { >= "4.07.0" } | ||
| "dune" { build & >= "2.5" } | ||
| "ppxlib" { >= "0.22.0" } | ||
| "ocaml-compiler-libs" |
There was a problem hiding this comment.
Are you really using ocaml-compiler-libs directly? I can only see uses of compiler-libs (those are two different libraries, one is a janestreet library, the other is a package included in OCaml itself)
There was a problem hiding this comment.
| "ocaml-compiler-libs" |
There was a problem hiding this comment.
It is the ocaml-compiler-libs. I use it to get Location.t. However, when linking the library I need to use the name compiler-libs in the dune file. I don't know why.
There was a problem hiding this comment.
That's because ppxlib uses ocaml-compiler-libs under the hood already so that makes it a transitive dependency
There was a problem hiding this comment.
Do you want to change your usages of compiler-libs by ocaml-compiler-libs in your dune files and re-release? Or do that later (the dependency would be a bit misleading here though)
There was a problem hiding this comment.
I can remove it in the next revison I make to the library.
packages/pla/pla.2.1/opam
Outdated
|
|
||
| depends: [ | ||
| "ocaml" { >= "4.07.0" } | ||
| "dune" { build & >= "2.5" } |
There was a problem hiding this comment.
Dune cannot be tagged as a build dependency (see ocaml/dune#2147)
| "dune" { build & >= "2.5" } | |
| "dune" { >= "2.5" } |
There was a problem hiding this comment.
This change got removed in your latest push-force
There was a problem hiding this comment.
I have applied the suggested change.
modlfo
force-pushed
the
opam-publish-pla.2.1
branch
2 times, most recently
from
2de7911 to
5f3c30e
Compare
modlfo
force-pushed
the
opam-publish-pla.2.1
branch
from
5f3c30e to
c654775
Compare
|
Thanks a lot! |
pla.2.1Pla is a simple library and ppx syntax extension to create composable templates based on verbatim strings
🐫 Pull-request generated by opam-publish v2.1.0